On Fri, Jul 05, 2024 at 11:10:08AM +0100, Joe Orton wrote: > On Tue, Jul 02, 2024 at 02:05:38PM +0200, Dmitry Belyavskiy wrote: > > In the long-term it would be better to provide a patch fixing build of the > > package. Probably adding -DOPENSSL_NO_ENGINE to build flags will work. > > Engines are deprecated. You should not use engines and should migrate to > > providers. > > I really think this is silly. Looking at the Boost headers they already > conditionalize support for ENGINE *in the way that OpenSSL upstream > intended*. > https://www.boost.org/doc/libs/1_74_0/boost/asio/ssl/detail/openssl_types.hpp > > #if !defined(OPENSSL_NO_ENGINE) > # include <openssl/engine.h> > #endif // !defined(OPENSSL_NO_ENGINE) > > So, no, Boost should not be "fixed". <openssl/configuration-*.h> should > simply "#define OPENSSL_NO_ENGINE" if you want Fedora packages to drop > ENGINE support. We have broken the way Fedora packages consume the > OpenSSL API - it should be reverted, we're just heaping unnecessary work > on other package maintainers. I wonder if it would be possible (of course it is technically possible, more like how hard it would be) to make the OpenSSL devel package conditionally define OPENSSL_NO_ENGINE if another package is not installed. I can think of at least two ways to do that: - alternatives (but maybe that's my Debian background talking) - #include_next games G'luck, Peter -- Peter Pentchev roam@xxxxxxxxxxx roam@xxxxxxxxxx peter@xxxxxxxxxxxxxx PGP key: https://www.ringlet.net/roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
Attachment:
signature.asc
Description: PGP signature
-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
