Dne 14. 05. 24 v 11:26 Tim Landscheidt napsal(a):
Vít Ondruch <vondruch@xxxxxxxxxx> wrote:%patch otoh (now) is a regular (though internally implemented) macro that is expanded with other macros and though can be used in other macros and expressions.Do I read correctly that we can now use `%patch` in e.g. `%check` section? Interesting. Is this documented?No, while %patch and %setup *could* be made available elsewhere now, they are still only available in %prep because that's the only place where they make sense.Working with Ruby, which is interpreted language, there are cases where we want to patch tests, while we want to keep them in their original form in the package. This might sound weird, but the thing is that for running tests, we might be limited by infrastructure. E.g. Koji does not have internet access, builders are slow, etc. So we might want to apply some patch to workaround such issues. I have no hopes convincing you. But thank you for clarification.This feels like the tests should be patched (and these patches upstreamed) to behave differently depending on some option
I don't disagree. I am all for upstreaming. But there are more pros and cons.
Vít
, and the spec file should then use this option to trigger the correct one. I don't know enough about Ruby to suggest The Way™ to pass this option; but usually environment variables will do. (Other test suites have tags that can be used to select tests that should (not) be run which might be another (upstreamable) solution.) Tim
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature
-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
