On Monday, 13 May 2024 at 12:14, Fabio Valentini wrote: > On Mon, May 13, 2024, 11:50 Dominik 'Rathann' Mierzejewski < > dominik@xxxxxxxxxxxxxx> wrote: > > > On Monday, 13 May 2024 at 01:00, Neal Gompa wrote: > > > On Sun, May 12, 2024 at 4:59 PM Sérgio Basto <sergio@xxxxxxxxxx> wrote: > > > > > > > > > > > > > > > > https://src.fedoraproject.org/rpms/gimp3 > > > > > > > > > > What the heck? This should have been gimp2 for the old version, not > > > gimp3 for the new version... > > > > Also, how did this pass review? > > > > License: LGPLv3+ > > > > And I'll answer myself: it hasn't or at least I can't find any review > > ticket. > > > > Nils, could you explain how this package ended up in Fedora? > > Standard procedure, everything seems to be in order: > > https://pagure.io/releng/fedora-scm-requests/issue/62152 Thanks, I couldn't find the link. > The review exception is valid because it's an alternative version of an > existing package, and Nils is also the maintainer of the existing package. Sure. That doesn't excuse importing a spec that doesn't follow current packaging guidelines. It'd be nice if such requests had to pass at least some automated checks (like successful scratch build, installability check, SPDX validation, i.e. basic sanity checks) before human approval is sought. I expect nobody wants to import broken stuff knowingly, but these things can be missed. > While most people prefer that alternative versions carry a "compat" suffix > (i.e. the new version is the one without the suffix, and the old version > has the suffix), this is - contrary to popular belief - not actually > required or even mentioned in the packaging guidelines. Also correct. And Nils, I'm not saying you did anything wrong. Just that it'd be a good idea to announce this, even if to invite testers. I actually have a GIMP user at home who might want to check it out. Thanks for working on the new GIMP version! Regards, Dominik -- Fedora https://fedoraproject.org Deep in the human unconscious is a pervasive need for a logical universe that makes sense. But the real universe is always one step beyond logic. -- from "The Sayings of Muad'Dib" by the Princess Irulan -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
