On Thu, Apr 4, 2024, 00:54 Philip Matura via devel <devel@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
On Thu, Apr 04, 2024 at 12:03:56AM +0200, Fabio Valentini wrote:
> On Wed, Apr 3, 2024 at 11:47 PM pfed--- via devel
> <devel@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Maybe we could add the `--allow-dirty` to the `%cargo_install` macro -
> > from the top of my head this should not break anything, but I'm not
> > sure. There does not seem to be a general "ignore-git" option for cargo.
> >
> > Or are there other ways to get this to work?
>
> The short answer is: No, "fedpkg local" is not expected to work for
> Rust packages, and probably won't ever work as expected for Rust
> packages.
>
> I am not really interested in adding the "--allow-dirty" flag (not
> sure if it would even work in this case), since building Rust packages
> with "fedpkg local" is not working for other reasons. Primarily,
> "fedpkg local" does not support dynamically generated BuildRequires -
> this is only supported when building in mock.
I don't know what you mean? For me after patching the macro locally
local builds work as expected. Maybe I'm overlooking something?
You might be lucky and just tried to package a Rust crate with no dependencies?
Dependencies on other Rust crates are only resolved dynamically at build time, which "fedpkg local" does not support. So it works "by accident" for Rust crates with no crate dependencies, but in general, it can't work.
Fabio
Philip Matura
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
