Frederic Berat wrote on 2023/11/27 22:23:
On Fri, Nov 24, 2023 at 12:07 PM David King <amigadave@xxxxxxxxxxxxx> wrote:The latest released versions of libxml2 have a couple of important changes in header files that have unintentionally caused some packages to fail to build without modification, including: * several functions now accept or return a const xmlError struct * cyclic dependencies in header files were fixed (by dropping some includes) Most failures that have been witnessed so far by davidlt while rebuilding RISCV packages, and have been related to the xmlError const change, but xmlsec1 was hit by the include changes: https://github.com/lsh123/xmlsec/pull/729 https://src.fedoraproject.org/rpms/xmlsec1/pull-request/4 As libxml2 is used rather widely, I expect more changes to come up over time, so please feel free to ask me for help (amigadave on IRC, or Cc <amigadave@xxxxxxxxxxxxx> on bugs) and I will be happy to submit patches upstream and do builds; I am a provenpackager, so happy to help. Thanks to davidlt for spotting the breakages!Hello, I made a mass rebuild of the packages that directly depend on libxml2, and found 115 packages (out of 621) with build failure correlated to the libxml2 update. Out of these 115 packages, 102 so far are highly related (i.e. they show xml related errors in the build logs). Few notes: - Since the new version of libxml2 is already in rawhide I made the mass rebuild on F39 with it instead of a rawhide build. That implies that some of the packages may already have been fixed but that still gives a rough idea on potential problems. I threfore started a mass-rebuild on rawhide to cross-check, but I don't have a report to give yet. - Out of the 13 packages that seem correlated but don't show obvious errors directly related to libxml2, there are still some quite suspicious ones, like cinnamon which fails due to a missing xml file. When you plan to do such an update, I can only recommend you to do a mass prebuild [1][2]. Full report can be found attached. I also added a log file listing the obvious failures. I hope that helps a bit. Fred. [1] https://copr.fedorainfracloud.org/coprs/fberat/mass-prebuild/ [2] https://gitlab.com/fedora/packager-tools/mass-prebuild
Note that looking at build log, I've noticed that "-Werror=implicit-function-declaration" is not in effect there. Actually (as Frederic said) this mass rebuild is on Fedora 39, and the above compilation flag change is on Fedora 40: https://fedoraproject.org/wiki/Changes/PortingToModernC Actually with libxml2 2.12.0, for example mlt (7.20.0) succees to compile with the message: ``` /builddir/build/BUILD/mlt-7.20.0/src/modules/jackrack/jack_rack.c:343:9: warning: implicit declaration of function `xmlParseFile`; did you mean `xmlSaveFile` ? [-Wimplicit-function-declaration] ``` This becomes error on Fedora 40. i.e. There will be more errors than that you provided. Regards, Mamoru -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
