On Tue, Jul 18, 2023 at 5:41 AM Richard W.M. Jones <rjones@xxxxxxxxxx> wrote: > The first error is: > > /home/rjones/d/fedora/polymake/rawhide/polymake-4.10/lib/core/src/perl/RefHash.xxs:737:11: error: ‘Perl_ck_fun’ was not declared in this scope; did you mean ‘Perl_cx_dup’? > 737 | return Perl_ck_fun(aTHX_ o); > | ^~~~~~~~~~~ > | Perl_cx_dup > ninja: build stopped: subcommand failed. > > As far as I can see that's the only missing / hidden Perl symbol. > > This symbol was hidden in: > https://github.com/Perl/perl5/commit/0351a629e71de127cbfd1b142e9eaa6069deabf5 > > As for what it does, that's more tricky. I believe what it's doing is > while Perl is parsing the input script, it is used to check that the > thing you are calling is a function. Unfortunately it's slightly more > complicated than that because it can convert some function-like things > to functions (returning the updated OP*). Also Perl_ck_fun is > complicated, to say the least: > > https://github.com/Perl/perl5/blob/a6d10131eee6ee336e4bd63f22a378e9d5ae40bd/op.c#L12522 > > For these reasons we can't just replace 'return Perl_ck_fun(aTHX_ o)' > with 'return aTHX_ o', nor can be copy the function into the polymake > source (since it calls other internal functions, but also for > licensing reasons). > > So I think this does require upstream attention. The code also calls save_pushptrptr (Pel_save_pushptrptr), another hidden symbol. Polymake has long had way too much knowledge of perl internals, which is why it has tended to break whenever a new perl version was released. It broke drastically this time. > Another note is this package requires ocaml-tplib which we orphaned. Right. I was going to remove that dependency, but the package broke from the perl update while we were still doing the OCaml 5 builds, so I never got the chance. At this point, I don't see how to keep it in Fedora until upstream does some major surgery on their code base. Thanks for looking at it! -- Jerry James http://www.jamezone.org/ _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
