OpenCOLLADA need a little c++ help

[Richard Shaw <hobbes1069@xxxxxxxxx>]

OpenCOLLADA has been failing to build with gcc 13 due to[1]:

error: possibly dangling reference to a temporary [-Werror=dangling-reference]
  315 |                 const auto & parents = dae.root().selectNodes("//*[@sid]/..");

The code in question[2] is:

  // InstanceWithExtra and other <instance_*> with "url" attribute
const auto & instances = root().selectNodes(
xpath_all + Strings::instance_animation +
xpath_or_all + Strings::instance_camera +
xpath_or_all + Strings::instance_controller +
xpath_or_all + Strings::instance_effect +
xpath_or_all + Strings::instance_force_field +
xpath_or_all + Strings::instance_formula +
xpath_or_all + Strings::instance_geometry +
xpath_or_all + Strings::instance_image +
xpath_or_all + Strings::instance_joint +
xpath_or_all + Strings::instance_kinematics_model +
xpath_or_all + Strings::instance_kinematics_scene +
xpath_or_all + Strings::instance_light +
xpath_or_all + Strings::instance_node +
xpath_or_all + Strings::instance_physics_material +
xpath_or_all + Strings::instance_physics_model +
xpath_or_all + Strings::instance_physics_scene +
xpath_or_all + Strings::instance_visual_scene
);
for (auto instance : instances)
if (auto url = ""> onAnyDAEURI(instance.line(), url.value());

There's a 2nd instance of the error but I think I can fix it once the path forward on the first is addressed.

Thanks,

Richard

[1] https://github.com/KhronosGroup/OpenCOLLADA/issues/661

[2] https://github.com/KhronosGroup/OpenCOLLADA/blob/master/DAEValidator/library/src/Dae.cpp#L78

_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue