On Tue, Jan 3, 2023 at 10:21 AM Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> wrote: > > On Tue, Jan 03, 2023 at 03:50:10PM +0100, Vít Ondruch wrote: > > > > Dne 03. 01. 23 v 14:20 Fabio Valentini napsal(a): > > > On Tue, Jan 3, 2023 at 2:14 PM Stephen Smoogen <ssmoogen@xxxxxxxxxx> wrote: > > > > > > > > > > > > On Tue, 3 Jan 2023 at 04:20, Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> wrote: > > > > > On Tue, Jan 03, 2023 at 09:32:58AM +0100, Vitaly Zaitsev via devel wrote: > > > > > > On 02/01/2023 21:44, Zbigniew Jędrzejewski-Szmek wrote: > > > > > > > - fedpkg mockbuild > > > > > > But it doesn't work correctly (will always use Release: 1) if you run > > > > > > "rpmbuild -bs foo-bar.spec" which is a very common scenario. > > > > > "Doctor, it hurts when I do that." > > > > > > > > > > 'rpmbuild -bs' is broken. Don't use it. > > > > > > > > > Could you please elucidate why the command that people have used for nearly 30 years and is the most documented on how to build rpms is broken? And how people should use instead when they may be dealing with an environment which doesn't allow fedpkg to work? [AKA I am working on a package which I want to submit for review so I need to build a @$@$% src RPM somehow and I am being told I can't use the built in command to do so] > > > "rpmbuild -bs" is not "broken", it just doesn't know about rpmautospec > > > (because it's implemented on top of RPM instead of *in* RPM), > > > > > > Oh, it does not know about more things, e.g.: > > > > ~~~ > > > > $ rpmbuild -bs ruby.spec > > error: /home/vondruch/fedora-scm/own/ruby/ruby.spec: line 132: failed to > > load macro file /home/vondruch/rpmbuild/SOURCES/macros.ruby > > 0< (%load) > > ~~~ > > Yes, this is what I was talking about too. Because rpmbuild does not set > %_sourcedir, it may fail to load some files. Even worse, it may load *wrong* > versions, e.g. when some old version is present in the ~/rpmbuild/SOURCES/. > Personally, I have dozens of stray files there from old rpm builds there… > > > So it does not handle more scenarios then just rpmautospec. > > > IMHO, it would be much better to recommend: > > > > $ touch sources > > $ fedpkg --release f38 srpm > > Ideally, fedpkg/rpkg would allow 'sources' to not exist and DTRT automatically. > It would just make everyone's life easier. > It already does. I use it for packaging I have in Git repos on pagure.io. -- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
