On Thu, Sep 29, 2022 at 12:01:13AM +0100, Sérgio Basto wrote: > On Fri, 2022-09-23 at 22:49 +0100, Sérgio Basto wrote: > > On Fri, 2022-09-23 at 22:39 +0100, Sérgio Basto wrote: > > > On Mon, 2022-09-19 at 09:08 +0200, Dan Horák wrote: > > > > On Fri, 16 Sep 2022 13:42:42 +0000 > > > > Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> wrote: > > > > > > > > > On Fri, Sep 16, 2022 at 03:35:29PM +0200, Florian Weimer wrote: > > > > > > * Zbigniew Jędrzejewski-Szmek: > > > > > > > > > > > > > So… we certainly don't want people having to declare the > > > > > > > dependency > > > > > > > manually everywhere. > > > > > > > > > > > > The packaging guidelines seem to say that the manual > > > > > > dependency > > > > > > is > > > > > > required, though. > > > > > > > > > > Yeah, you need *some* dependency. But opencryptoki has > > > > > BR:systemd-devel, and systemd-devel has R:systemd, which has > > > > > the > > > > > Requires(meta) under discussion. So an explicit BR:systemd-rpm- > > > > > macros > > > > > should be redundant. > > > > > > > > the BR: systemd-devel in opencryptoki might be just a historical > > > > relict, because it used to be required to define the various > > > > macros > > > > (IIRC) > > > > > > > > > > > > Dan > > > > > > > > > Today clamav fails to build on rawhide again, this time because > > > make > > > install on mock doesn't install systemd files ! > > > > > > scratch build > > https://koji.fedoraproject.org/koji/taskinfo?taskID=92286295 > > > systemd-devel no longer has systemd dependency on F37+, now we also > need BuildRequires: systemd I don't expect clamav needs systemd to build. It probably needs systemd-devel and systemd-rpm-macros. It is true that systemd-devel used to pull in systemd. It was something of an accident: systemd-devel had an artificial dependency on systemd-pam, which in turn had a dependency on systemd. The artificial dep was added to make system-pam a multiarch package. At some point this was solved properly and and hack was dropped. I don't think we want systemd-devel to R:systemd. systemd-devel is about various headers and libraries, and the systemd runtime is a separate thing. I now pushed a commit to add in systemd-devel: Requires(meta): (%{name}-rpm-macros = %{version}-%{release} if rpm-build) This means we'll get systemd-rpm-macros in rpm buildroot if systemd-devel is installed. We had the same line on systemd itself. This way one doesn't need to explicitly BR:systemd-rpm-macros is either BR:systemd or BR:systemd-devel is specified. Zbyszek _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue