Hi, On Fri, 2022-03-04 at 18:07 +0100, Kamil Dudka wrote: > On Friday, March 4, 2022 4:17:01 PM CET Sérgio Basto wrote: > > I think you missed the > > https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds > > When the change landed, I had to fix all my packages to build although > they > had been using out of source builds since the beginning. Now I have to > fix > them again. Maintaining a spec file that works on RHEL-7..9 and on all > supported releases of Fedora is more and more difficult for no good > reason > but I am not giving it up for now: > > https://github.com/csutils/csdiff/commit/df8d918c > https://github.com/csutils/csdiff/commit/9ec45f67 > I would have to waste some time to understand your commits, but at first glance they are not correct, I would also have to analyze how the macros are going on el7, I think cmake3 macros from epel-7 already assumed all this. I advise anyone to carefully read the wiki page. We have two options, or keep the directories, or remove the all directories, from the build. if we don't want to change anything we can use Martin's solution that is add: %global __cmake_in_source_build 1 otherwise we should not use any directory and use: %undefine __cmake_in_source_build Best regards, > Kamil > > -- Sérgio M. B. _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
