On Fri, 2022-03-04 at 16:04 +0100, Michal Schorm wrote: > On Fri, Mar 4, 2022 at 3:40 PM Sérgio Basto <sergio@xxxxxxxxxx> wrote: > > The fix is just remove "\ ." (the dot) on %cmake > > That isn't a fix, that's a workaround for a broken CMake - atleast > that I believe, as you can read in that BZ. > I haven't found anything on CMake upstream that would suggest such > change is needed, I found the contrary. > > And even if this change would be actually intended, it would be nice > from the CMake maintainer to announce it. I think you missed the https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds (Targeted release: Fedora 33 ) and https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ My deduction also came from here: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/IGQFBIEBMFHIAHY45SKF5MXOJP43TVQS/ i.e. the builds that still aren't completely out of the source (i.e. have the dot), can have (new) problems, one solution is make the build out of the source as recommended on https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds Best regards, > On Fri, Mar 4, 2022 at 3:40 PM Sérgio Basto <sergio@xxxxxxxxxx> wrote: > > > > On Fri, 2022-03-04 at 09:26 -0500, Steven A. Falco wrote: > > > There is a new FTBFS for KiCad [1]. I filed an issue with KiCad > > > [2] > > > and got a comment from the project leader: > > > > > > This looks like cmake issue to me. For some reason cmake is > > > creating an incorrect build folder: > > > > > > -- Build files have been written to: > > > /builddir/build/BUILD/kicad- > > > 6.0.2 > > > > > > so the build command: > > > > > > + /usr/bin/cmake --build redhat-linux-build -j6 --verbose > > > > > > cannot find the redhat-linux-build folder that was passed on > > > the > > > cmake command line. > > > > > > In the last successful build, we have: > > > > > > -- Build files have been written to: > > > /builddir/build/BUILD/kicad- > > > 6.0.2/redhat-linux-build > > > + /usr/bin/cmake --build redhat-linux-build -j6 --verbose > > > > > > For some reason, the build file directory has changed: > > > > > > Success case: /builddir/build/BUILD/kicad-6.0.2/redhat-linux-build > > > Failure case: /builddir/build/BUILD/kicad-6.0.2 > > > > > > Is this a bug in cmake or did something in RPM macros change? > > > > > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=2060781 > > > [2] https://gitlab.com/kicad/code/kicad/-/issues/11043 > > > > > > > The fix is just remove "\ ." (the dot) on %cmake > > in line > > https://src.fedoraproject.org/rpms/kicad/blob/rawhide/f/kicad.spec#_92 > > > > > > > > > > > Steve > > > _______________________________________________ > > > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > > > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > > > Fedora Code of Conduct: > > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > > > List Guidelines: > > > https://fedoraproject.org/wiki/Mailing_list_guidelines > > > List Archives: > > > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx > > > Do not reply to spam on the list, report it: > > > https://pagure.io/fedora-infrastructure > > > > -- > > Sérgio M. B. > > _______________________________________________ > > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > > Fedora Code of Conduct: > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > > List Guidelines: > > https://fedoraproject.org/wiki/Mailing_list_guidelines > > List Archives: > > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx > > Do not reply to spam on the list, report it: > > https://pagure.io/fedora-infrastructure > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx > Do not reply to spam on the list, report it: > https://pagure.io/fedora-infrastructure -- Sérgio M. B. _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
