Re: Package notes feature causing build paths to be embedded

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 03, 2022 at 10:36:02AM -0500, Simo Sorce wrote:
> On Thu, 2022-02-03 at 16:22 +0100, Petr Pisar wrote:
> > V Thu, Feb 03, 2022 at 09:26:09AM -0500, Simo Sorce napsal(a):
> > > On Thu, 2022-02-03 at 15:15 +0100, Petr Pisar wrote:
> > > > V Thu, Feb 03, 2022 at 08:56:20AM -0500, Simo Sorce napsal(a):
> > > > > On Thu, 2022-02-03 at 10:09 +0100, Florian Weimer wrote:
> > > > > > * Richard W. M. Jones:
> > > > > > 
> > > > > > > Thinking about this a bit more, the implementation of this feature
> > > > > > > simply seems to be wrong.  RPM already has a final stage where it
> > > > > > > strips ELF files and builds debuginfo.  Why wasn't the addition of
> > > > > > > package notes done there?
> > > > > > 
> > > > > > The package notes are in an allocatable section, to be mapped at run
> > > > > > time, so that they end up in core files.  As far as I know, it's not
> > > > > > reliably possible to add such data to an ELF file after the final
> > > > > > (non-relocatable) link.
> > > > > > 
> > > > > > We would have to pre-allocate some fixed space and fill it in later.
> > > > > > 
> > > > > > Cleaner approaches are possible if we teach the core dumper how to copy
> > > > > > select data from non-allocated sections.  I think we would then need
> > > > > > just a placeholder program header.
> > > > > 
> > > > > While it is nice to discuss future options, do we have a way to fix
> > > > > FTBFS's in rawhide _now_ ?
> > > > > 
> > > > You can disable embedding the package notes by undefining _package_note_file
> > > > macro in the package which builds in the linker flags. See
> > > > <https://src.fedoraproject.org/rpms/perl/c/4751b01e52fad1ef9c3012675791d979436ff8fe.patch>
> > > > for an example. Kudos to Jitka.
> > > 
> > > No I could not, because I still got the dependent krb5 package to bring
> > > in another unavailable linker script.
> > > 
> > > FTR we resolved this by rebuilding krb5-libs *without* notes, and then
> > > I could rebuild python-gssapi also without notes.
> > > 
> > > However I resent a bit that I had to chase down this problem myself,
> > > days after it had already been exposed, and basically manually disable
> > > this feature for a large part of Fedora (anything that links to krb5
> > > now is missing these notes, rights?)
> > 
> > No. krb5-libs will miss its notes. But python-gssapi will contain its correct
> > notes. (Provided python-gssapi links to krb5-libs dynamically. I don't know
> > whether the notes only record a source package name the ELF file belongs to,
> > or whether they try to track origin of all object files the ELF consists of.)
> 
> I had to undefine notes on python-gssapi as well, so not notes, period.

Similarly I added the %undefine to every OCaml package and
every package built using OCaml today.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux