On Wed, Dec 30, 2020 at 05:08:03PM -0700, Chris Murphy wrote: > > Upgrades of customized configurations that deviate significantly from > > defaults aren't supported. It's best effort. We can't be blocking on > > people's customizations. > > > > I think we can come pretty close to atomically renaming > > > > /EFI/fedora/grub.cfg /EFI/fedora/grub.cfg.old > > /EFI/fedora/grub.cfg.new to /EFI/fedora/grub.cfg > > > > And at least ensure the user can boot the old one, but even this I > > think is pretty unlikely. It's really a teeny tiny window of failure > > opportunity. And based on my reading of rename() if the files are > > already all present, and all we're doing is renaming them, there > > shouldn't be a case where grub.cfg is either missing entirely or zero > > bytes. > > > > But dm-log-writes can help confirm or deny this. What I don't know is > > if this can be done with bash. The convert script probably needs to be > > done in C. Or at least the rename and sync parts. > > > Oh I forgot the part about the convert script testing for custom > grub.cfg. Maybe it's possible to parse it first, and if it's custom, > bail. If it's non-custom then convert it. > > And a variation where we have an opt-in for this convert script for > Fedora 34 cycle. And then ship it and do the conversion in Fedora 35. > > I think either never fixing this, or never updating systems to the > "new way" are both untenable. We saw with the BLS switch many users > depend on doing in place upgrades. Many were pushing 4 or more years. I think conversion script would be needed for people doing upgrades. But first of all - documentation! It should be clear what GRUB expectations are, where the config file should be and so on. BLS conversion was hard because it was undocumented. One of the crucial scripts (grubby? install-kernel?) has been changing behaviour upon existence of some file or directory in /boot (was is loader/?). It was undocumented and so counter-intuitive that cannot recall details after merely two years. Right now the best information about how Fedora boots and what happens on kernel installation can be founds on AdamW's blog. This is not perfect :( -- Tomasz Torcz 72->| 80->| tomek@xxxxxxxxxxxxxx 72->| 80->| _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
