On Wed, Dec 30, 2020 at 2:09 PM Javier Martinez Canillas <javier@xxxxxxxxxxxx> wrote: > On Wed, Dec 30, 2020 at 9:22 PM Adam Williamson > <adamwill@xxxxxxxxxxxxxxxxx> wrote: > > * We wouldn't have a "consistent configuration" across everybody, > > really, because anyone who upgraded from pre-F34 would still have the > > old config; every bootloader debugging session ever would start by > > figuring out which case this was. > These are all fair points. My worry is that trying to switch to the > new configuration on upgrades could lead to issues for people that > have custom GRUB configs. That was the case when we did the switch to > using BLS snippets and I don't really want to repeat that experience > for users. That problem was the result of quite old core.img in the MBR gap (or BIOS Boot partition). As that change simultaneously depended on shipping a new GRUB module without a way to update the core.img with up-to-date GRUB modules, there was a known weak spot that we even knew of in advance. Upgrades of customized configurations that deviate significantly from defaults aren't supported. It's best effort. We can't be blocking on people's customizations. I think we can come pretty close to atomically renaming /EFI/fedora/grub.cfg /EFI/fedora/grub.cfg.old /EFI/fedora/grub.cfg.new to /EFI/fedora/grub.cfg And at least ensure the user can boot the old one, but even this I think is pretty unlikely. It's really a teeny tiny window of failure opportunity. And based on my reading of rename() if the files are already all present, and all we're doing is renaming them, there shouldn't be a case where grub.cfg is either missing entirely or zero bytes. But dm-log-writes can help confirm or deny this. What I don't know is if this can be done with bash. The convert script probably needs to be done in C. Or at least the rename and sync parts. -- Chris Murphy _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
