Re: Need assistance for luxcorerender to use c++14

Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> · Sun, 20 Sep 2020 10:58:20 -0700



    On 2020-09-20 4:49 a.m., Richard Shaw
      wrote:

    
        On Sat, Sep 19, 2020 at 8:27 PM Luya Tshimbalanga
          <luya@xxxxxxxxxxxxxxxxx> wrote:

        
              Thanks for quick response. The suggestion seems to
                work. Unfortunately, the build failed on openvdb (either
                using the bundled and 7.1.0 version) while working fine
                on Fedora 32.

              
              https://koji.fedoraproject.org/koji/taskinfo?taskID=51860207
            
          
          The error is more informative than you think, but only
            because I've run into this with another package. In boost
            1.73 they made a change to the scope of the placeholders[1]
            to not conflict with std namespace.
          

          "Changed
              all uses of the boost.bind placeholders to use the boost::placeholders namespace."
          

          Something like this may work, but it's untested. I don't
            see where any boost headers are being included, but they
            must be somewhere to use boost::bind. If it doesn't I would
            try adding "#include <boost/bind/bind.hpp>" in
            bakesputhread.cpp.

          
          Index:
            LuxCore-luxcorerender_v2.4/src/slg/engines/bakecpu/bakecputhread.cpp

===================================================================

            ---
LuxCore-luxcorerender_v2.4.orig/src/slg/engines/bakecpu/bakecputhread.cpp

            +++
            LuxCore-luxcorerender_v2.4/src/slg/engines/bakecpu/bakecputhread.cpp

            @@ -340,7 +340,7 @@ void BakeCPURenderThread::RenderLightSam

                    const PathTracer &pathTracer =
            engine->pathTracer;

                    
                    const PathTracer::ConnectToEyeCallBackType
            connectToEyeCallBack = boost::bind(

            -                      
            &BakeCPURenderThread::RenderConnectToEyeCallBack, this,
            mapInfo, _1, _2, _3, _4);

            +                      
            &BakeCPURenderThread::RenderConnectToEyeCallBack, this,
            mapInfo, boost::placeholders::_1, boost::placeholders::_2,
            boost::placeholders::_3, boost::placeholders::_4);

             
                    pathTracer.RenderLightSample(state.device,
            state.scene, state.film, state.lightSampler,

                                    state.lightSampleResults,
            connectToEyeCallBack);

          
          Thanks,
          Richard
          

           [1] https://www.boost.org/users/history/version_1_73_0.html
        
      
    This patch is the right solution as luxcorerender finally
      successfully mock built. Thank you for the help.

    
    --
    
    Luya Tshimbalanga
Fedora Design Team
Fedora Design Suite maintainer
  

_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx