Re: Need assistance for luxcorerender to use c++14

[Andy Mender <andymenderunix@xxxxxxxxx>]

On Sat, 19 Sep 2020 at 22:27, Richard Shaw <hobbes1069@xxxxxxxxx> wrote:

On Sat, Sep 19, 2020 at 3:16 PM Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> wrote:

Hello team,

openvdb is updated to 7.1.0 in Rawhide and luxcorerender needs to switch
to -std=c++14 similar to that upstream ticket:
https://github.com/AcademySoftwareFoundation/openvdb/issues/795.

Is there anyone knowing how to do it on the spec file?

https://src.fedoraproject.org/rpms/luxcorerender/

It seems  "sed -i 's|${CMAKE_CXX_FLAGS} -std=c++11|${CMAKE_CXX_FLAGS}
-std=c++14|' CMakeLists.txt"  is not enough because "-std=c++11" still
comes back.

Looks like it's specified here:

 cmake/PlatformSpecific.cmake

I would just patch it instead.

I would also suggest patching the main CMakeLists file, for instance the following way:

set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

If that's not too invasive, of course.

_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx