On Tue, 2020-04-14 at 13:58 +0200, Miro Hrončok wrote:
> On 14. 04. 20 13:39, Nils Philippsen wrote:
> > So, to make this more robust against problems like you described,
> > we
> > should decouple what's run in the build root from a specific minor
> > version of Python and the rpm Python package (and remove the
> > superfluous Koji dependency). This shouldn't be much work, the
> > biggest
> > piece is probably to make it get by without using the rpm Python
> > package (for comparing EVRs and to expand macros), but a tiny
> > ctypes
> > wrapper around rpmlib should solve this for us.
>
> Or even running `rpmdev-vercmp` and `rpm --eval` with subprocess:
I'd rather not pull in rpmdevtools -- which depends on Perl and a
couple 3rd party Perl packages. ;)
One thing I missed in my previous mail was that we already shell out to
rpmspec ("rpm --specfile ...") to query the epoch/version of the spec
file, but that should be okay, too -- it's part of rpm-build which we
need for building the SRPM at that point anyway.
Nils
--
Nils Philippsen "Those who would give up Essential Liberty to
Software Engineer purchase a little Temporary Safety, deserve neither
Red Hat Liberty nor Safety." -- Benjamin Franklin, 1759
PGP fingerprint: D0C1 1576 CDA6 5B6E BBAE 95B2 7D53 7FCA E9F6 395D
old: C4A8 9474 5C4C ADE3 2B8F 656D 47D8 9B65 6951 3011
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
