On Wed, Aug 14, 2019 at 8:49 PM Robbie Harwood <rharwood@xxxxxxxxxx> wrote:
> Here's the scriptlet:
>
> %triggerun libs -- krb5-libs < 1.15.1-5
> if ! grep -q 'includedir /etc/krb5.conf.d' /etc/krb5.conf ; then
> sed -i '1i # To opt out of the system crypto-policies
> configuration of krb5,
> remove the\n# symlink at /etc/krb5.conf.d/crypto-policies which will
> not be
> recreated.\nincludedir /etc/krb5.conf.d/\n' /etc/krb5.conf
> fi
> exit 0
>
> So... there's not actually a call to awk. And the last version of
> Fedora to have anything older than 1.15.1 was F28.
Please CC maintainers when discussing their package. We like it because
it avoids us getting blindsided by requirements/changes, and sometimes
we know things about our packages and can be helpful :)
Absolutely we need to engage with maintainers when debating changes. Doing this in isolation would basically mean failure.
There are two uses of awk: one at build-time, and one for the triggers.
I assume no one cares that I need awk to build. You're correct that the
use for the triggers can probably go away since they're aren't any right
now, but... does this actually matter? Please file a bugzilla if so.
> We don't supports updates from F28 to F31 (and certainly not updates
> from F28 when it was rawhide), so the scriptlet is no longer necessary
> at all. It has come and gone a few times throughout history but the
> dependency has remained.
Just because something /can/ go doesn't mean it /should/.
Yep!
A trigger
that doesn't fire won't hurt anything, and its removal is more noise to
filter through. And there are often other considerations: for instance,
the el8 spec file is branched from the Fedora one - el7 has a
1.15-series krb5. The upgrade window I have to support is larger than
what's mandated by Fedora - and that's fine! It's not causing any
problems for other things, so it doesn't matter to anyone but me.
Thanks,
--Robbie
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Adam Šamalík
---------------------------
Red Hat
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
