On Wed, Jul 24, 2019 at 9:57 AM Tom Hughes <tom@xxxxxxxxxx> wrote: > > On 24/07/2019 13:32, Josh Boyer wrote: > > On Wed, Jul 24, 2019 at 8:02 AM Miro Hrončok <mhroncok@xxxxxxxxxx> wrote: > >> > >> On 24. 07. 19 10:24, Tom Hughes wrote: > >>> That said, having to go round adding a mega ugly config file > >>> to every package that looks an awful lot like an internal braindump > >>> from some system doesn't really inspire confidence, or make for an > >>> easy way of opting in. > >> > >> This. The gating.yaml file is terrible. > > > > Do either of you have a better suggestion? > > Well more ordinary YAML would be a good start. > > I mean I literally had to go and try and read the YAML spec > to try and work out what it was doing and let me tell you, for > something that I had always thought was a simple format it has > a very long and hard to read spec... > > So a single document would be good, and get rid of the tags > which I assume are the result of serialising objects with > those name. > > The very.long.reverse.domain.test.names are not ideal. > > Then there's decision_context which apparently does nothing > but has to be there. > > Is there any rule type other than PassingTestCaseRule? > > If not then what's wrong with: > > --- > rules: > fedora-*: > - dist.abicheck > - dist.rpmlint > fedora-30: > - my.special.text > > or something equally simple, which just a list of tests > to require for each version. > I'd like to second that simpler hierarchy, but I'd say switching to TOML would make it considerably more simple to understand and imposes limits on the format so that it can't get wildly complicated. gating.toml: [[rules]] [[rules.fedora]] dist.abicheck = true dist.rpmlint = true [[rules.fedora.30]] my.special.test = true [[rules.epel]] dist.abirestrict = true [[rules.epel.8]] dist.modularcheck = true [[tests]] my.special.test = ["/path/to/test", arg1, arg2] Under no circumstances should the driving system for checks be too complex for people to grok. -- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
