Re: Tagging commit hashes of Koji builds in dist-git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 06, 2019 at 02:07:18PM -0500, Dennis Gilmore wrote:
> On Thu, Jun 6, 2019 at 7:11 AM Neal Gompa <ngompa13@xxxxxxxxx> wrote:
> >
> > On Thu, Jun 6, 2019 at 7:53 AM Florian Weimer <fweimer@xxxxxxxxxx> wrote:
> > >
> > > Is there a reason why we do not tag dist-git commits, using a name which
> > > is derived from the NEVR from a Koji build?
> > >
> > > How well does Git scale with thousands of tags?
> > >
> >
> > We used to back in the CVS days, because we needed it for plague. Koji
> > blocks duplicate submissions anyway, so it stopped being needed when
> > we transitioned to Git.
> 
> it was not plague that needed it, using tags was the only way to
> cjeckout the intended output, they had the problem that they were not
> immutable, if you made a typo you forced in a new tag so you did not
> need to bump the nvr
> 
> > We're going to probably introduce it for some automation in the near
> > future, though.
> >
> > Git is not great with thousands of any kind of refs, be it branches or
> > tags. It still works, it's just things like 'git log' get kind of
> > expensive.
> 
> koji stores the git hash for all builds, writing a script to get the
> hash for a given nvr would be trivial. it just means you have to be
> online to retrieve the data than being able to get the date while
> disconnected, if it was stored in git.

I'd also point out that the link is also made in pagure, for example: 
https://src.fedoraproject.org/rpms/kernel/c/ead55fdbc7606e96fb1436249e4d121c5119218b?branch=master

Basically, we listen for koji build results and "flag" the commit which was used
for the build with the outcome (success/failure) of the build.
Here is another example who both succeeded and failed to build in koji:
https://src.fedoraproject.org/rpms/0ad/c/d43ffc4721e7c5d6af33e9bc26b739ec6802cb76?branch=master

If this needs to be made more easily discoverable via the API, we can adjust
pagure for this.


Pierre
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux