Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Igor, your change broke my package.  Whatever automation you used should have taken into account that %post sections don't end until the next RPM directive.  %ifarch does not end a %post section.

diff --git a/ocp.spec b/ocp.spec
index 0d6fd28..2495ab5 100644
--- a/ocp.spec
+++ b/ocp.spec
@@ -139,9 +139,6 @@ cp -p license-images.txt license-videos.txt %{buildroot}%{_pkgdocdir}
 %{_datadir}/applications/*ocp.desktop
 %config(noreplace) /etc/ocp.ini
 
-%post
-/sbin/install-info %{_infodir}/ocp.info.gz %{_infodir}/dir || :
-
 %ifarch %{ix86}
 %if %{?_with_i386asm:1}%{!?_with_i386asm:0}
 # This is the i386 assembly version.  We need to allow text relocations.
@@ -162,11 +159,6 @@ restorecon -R %{_libdir}/ocp-* || :
 %endif
 

On Fri, Dec 21, 2018 at 09:25:13AM +0100, Igor Gnatenko wrote:
> If I manage to get this approved and done before mass rebuild, I'll
> just push changes without bumping anything. If it will happen
> during/after mass rebuild, I'll also bump.
> 
> I'm hoping to complete it before mass rebuild.
> 
> On Thu, Dec 20, 2018 at 6:55 PM Kevin Fenzi <kevin@xxxxxxxxx> wrote:
> >
> > On 12/20/18 2:35 AM, Dominik 'Rathann' Mierzejewski wrote:
> > > On Thursday, 20 December 2018 at 11:29, Richard Hughes wrote:
> > >> On Thu, 20 Dec 2018 at 10:16, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > >>> So I say +100 to just pushing the changes directly, as said
> > >>> people can always revert them.
> > >>
> > >> Completely agree. For my packages I'd totally prefer things just
> > >> magically be done without any action on my part.
> > >
> > > Same here and I'm in ACLs for ~100 packages, too. I definitely don't
> > > want to deal with a 100 PRs, for something so trivial. I'll revert
> > > if necessary, no big deal. Thanks for doing this to Igor, by the way.
> >
> > Yes, thanks!
> >
> > However, some clarification: do you intend to just remove the scriptlets
> > and thats it? Or, also bump version and add a changelog entry? or also
> > that and do a build?
> >
> > I'm fine with any of those, but I guess builds could interfere with
> > people who are in the middle of rebuilding some stacks.
> >
> > kevin
> >
> >
> >
> > _______________________________________________
> > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
> _______________________________________________
> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx

-- 
Charles R. Anderson, JNCIE-SP		cra@xxxxxxx
Network Architect			(508) 831-6110
Network Operations - Morgan Hall	(508) 831-6666
Worcester Polytechnic Institute	    Fax (508) 831-6669
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux