On 07/14/2018 12:47 AM, Kevin Fenzi wrote:
On 07/12/2018 07:45 AM, Miro Hrončok wrote:
I second that. When we mass filled PRs with python2 related changes it
was always a Red Hat maintained software, where people were basically
telling us: "no, we won't accept your PR here, we maintain the specfile
somewhere else". It was very unpleasant experience and usually such
maintainers expects us to:
1) find their canonical spec file location and figure out what special
branch we need to apply the patch to
2) wait for a new release of their software to happen and specfile
changes be "backported" into Fedora (sometimes took months)
Some maintainers were kinder than others, taking the changes and
applying them in their god-knows-where mainained spec files. Some where
not.
We don't need to make the rule less strict, we need to find a way to
enforce it. The current state (people ignoring this rule) makes
contributing to Fedora even harder than it already is.
I don't see that there is any way to enforce it. I suppose you could try
and have a hook to detect it, but it could well have false positives and
block legit commits.
Perhaps once we no longer use specs we can solve this. ;)
We can always have rpm spit out warnings first and errors later on.
With RHEL 5 and its contemporaries EOL by now, turning Buildroot: into a
warning seems like an actual possibility. Finally.
- Panu -
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/EMFZ7PO3JO3SLZ7AJ3XTM6PIWZ4NRKVJ/
