On 07/04/2018 03:18 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Jul 03, 2018 at 02:02:16PM -0500, Jason L Tibbitts III wrote: >> I ran the find-needless-defattr command from >> https://pagure.io/fedora-misc-package-utilities to find specfiles which >> include a non-default-changing %defattr as the first line of a %files >> section. This found 2513 packages. Because this number is so large, I >> was not able to verify each result manually but I did check a random >> sample of 50 packages and found the results to be correct. > >> Since this >> change is so simple, I may begin doing automated cleanup once F29 >> branches but feel free to fix your packages at any time. Since I am >> running this against the nightly specfile tarball, a rebuild is not >> needed for the script to notice that a package has been fixed. > > What about just doing a mass specfile update now? I think asking > individual maintainers to fix their packages isn't worth their > time. It's a safe change, just announce it, and patch all 2513 > packages a week later, without building. Also, there's no reason imho > to delay this until after branching, now is very good time for this > kind of fix. I agree. If this could be done before mass rebuild we can catch any issues/typos/mistakes in this with the mass rebuild. kevin
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/XD7PSMZSGOYSHNSHTRXEQQFFMCVUAROK/