On Wed, Jun 20, 2018 at 8:54 PM Gerald B. Cox <gbcox@xxxxxx> wrote:
On Wed, Jun 20, 2018 at 3:26 PM, Adam Williamson <adamwill@xxxxxxxxxxxxxxxxx> wrote:On Wed, 2018-06-20 at 13:15 -0400, Stephen Gallagher wrote:
> On Wed, Jun 20, 2018 at 12:34 PM Gerald B. Cox <gbcox@xxxxxx> wrote:
>
> The proper behavior here would be for these services not to be marked as
> "failed" when the appropriate hardware is not present. When possible, we
> should be using systemd's Condition* features to skip attempting to start
> it at all, but for things where we can't know it ahead of time, we should
> modify the start script to look for appropriate error codes/messages and
> treat the service as "success" if it's skipped because it's not supported
> on the current hardware.
Well, for rngd, the maintainer actually argued that he does *not* think
this is the "proper" behaviour. See
https://bugzilla.redhat.com/show_bug.cgi?id=1490632#c11 . I don't agree
with him (as you can, er, tell from the subsequent discussion), but it
seemed worth noting it's not a universally agreed truth.
(I don't *think* he'd object to a Condition-type fix, though, if we
could come up with a reliable one).
I believe we're missing something fundamental here. If a program/service etc. requires specific hardware to workand it can't gracefully handle situations where that hardware is not present - it shouldn't be a default.The way to handle this (and other similar situations) is to take away the default status until it can handlesituations where the hardware doesn't exist. This is systems programming 101 - and frankly I am abit surprised it's a matter of debate.
No one on this list is disagreeing that the defaults should not degrade the system. I *do* think that your response is an overreaction: just because software may have bugs on your hardware doesn't mean that it should be turned off entirely. If it's causing problems for a small subset of users, they can be manually disabled.
These services provide CONSIDERABLE benefit on the hardware that supports it. Removing that as a default for those systems would be a significant regression. That's not an acceptable solution.
Most of the people on this thread seem to agree: we can conditionalize the defaults so it is either skipped or at least does not mark the service as "failed" if the necessary hardware is not present. People are already working on doing this.
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/UQYDWO6O3SOCJPCWHL66PVQADIDKBD4R/