On Thu, 2018-03-08 at 22:25 -0500, Dusty Mabe wrote: > > On 03/08/2018 08:17 PM, Fedora compose checker wrote: > > Missing expected images: > > > > Atomichost qcow2 x86_64 > > Atomichost raw-xz x86_64 > > This is kind of interesting.. I see these images in the compose: > > https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20180308.n.2/compose/CloudImages/x86_64/images/ > > I wonder if the name should be Fedora-AtomicHost-Rawhide-20180308.n.2.x86_64.qcow2 > and that's why it's complaining? We should be able to fix that by updating > this line: https://pagure.io/pungi-fedora/blob/master/f/fedora.conf#_376 Well, nearly. It's not in fact based on the filename, but the subvariant property of the metadata. But you're nearly there, as you can see just a few lines below: 'subvariant': 'Atomic', I didn't realize / remember, when reviewing your changes, that only the ostree installer images are actually produced from the AtomicHost variant (note: these images wind up with AtomicHost as their subvariant as well as their variant, IIRC we use the variant as the subvariant any time there isn't an *explicit* subvariant), while the other Atomic images are produced in the CloudImages variant. I'd suggest that, yes, we should change the names *and* subvariants for those image definitions. (Note, it annoys me immensely that we just flat out specify all these 'name' fields. They should be generated from the metadata, not just...written down. But that's another issue.) -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
