-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 03/08/2018 11:18 PM, Adam Williamson wrote: > On Thu, 2018-03-08 at 22:25 -0500, Dusty Mabe wrote: >> >> On 03/08/2018 08:17 PM, Fedora compose checker wrote: >>> Missing expected images: >>> >>> Atomichost qcow2 x86_64 >>> Atomichost raw-xz x86_64 >> >> This is kind of interesting.. I see these images in the compose: >> >> https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20180308.n.2/compose/CloudImages/x86_64/images/ >> >> I wonder if the name should be Fedora-AtomicHost-Rawhide-20180308.n.2.x86_64.qcow2 >> and that's why it's complaining? We should be able to fix that by updating >> this line: https://pagure.io/pungi-fedora/blob/master/f/fedora.conf#_376 > > Well, nearly. It's not in fact based on the filename, but the > subvariant property of the metadata. But you're nearly there, as you > can see just a few lines below: > > 'subvariant': 'Atomic', > > I didn't realize / remember, when reviewing your changes, that only the > ostree installer images are actually produced from the AtomicHost > variant (note: these images wind up with AtomicHost as their subvariant > as well as their variant, IIRC we use the variant as the subvariant any > time there isn't an *explicit* subvariant), while the other Atomic > images are produced in the CloudImages variant. I honestly think we should - - #1 - make Cloud an empty variant (It's useless, and we build repos for no reason) - - #2 - Cloud base images get built from Everything and put in Cloud/ directory - - #3 - Atomic Host cloud images get put in AtomicHost/ directory > > I'd suggest that, yes, we should change the names *and* subvariants for > those image definitions. PR https://pagure.io/pungi-fedora/pull-request/575# > > (Note, it annoys me immensely that we just flat out specify all these > 'name' fields. They should be generated from the metadata, not > just...written down. But that's another issue.) > -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEPb6zG5c6sV89tRYPMwLb1zlS5nEFAlqjQ98ACgkQMwLb1zlS 5nGAfA//e5WS5LvChfBOIqpmNPIk6WXofao+5R8JyOPDcRuWZII9nyJZDDMjYoEp yy/ljvqJTgL/QZMcv6fNjSO4lYZo0NAx2LQlLW1WP5zrbVFMzpEpYc4+TJ/zUr3D G30g+aytCeg/Nw1Dhz8zHIc8UwkpiToDIVPKzhhPBhgiedLkeQC+a/nNghMlFJPj kAOcHRDfdXQazK0pYV+Wf5eTAPLbSeXz1kv3OXEqg8uYMM1eS0zVgZ3C2X7uDlUi 1m+f9LrEIKW789FpjCf08nu1HXLoikmJrzvoNHM/j+V3PQCA7nFfY0eN2iFL/6ML loYc/Xa9nKi/6xNsSTYio7GlrQvrzmtVh6uQB1zrLyZHduaEVE2m+tmQl12UvuhW Z5YBAU2XU2tC0w+KUekB0tsv60YP6zJDD5c1ElBqwSj+U7jK6AL0lUUXf8aAs126 LxTSvLsXtjh1q5wDu/t/50jYmZ8+du3VbYtwVkcC3u8ekN2VNNJlW/bPTgGi+K2F 81y2AG5ZABFhLZjT5F0BSDYCrQOufUDJ/BDjdnfHn9V/MeZ3qm0mDT4cm8XtpbZS +/3KXoMOfLSSALW86lFvcFuj/xBacfQqkxupfiL9E8f9iw4np85qFGmQZUCxGUF+ VMeV7aERcEGlGrVAvsAtgSnXXshlRdylioD7QkvE7Nux4umYaRE= =2A4d -----END PGP SIGNATURE----- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
