On Fri, Jan 05, 2018 at 02:03:17PM +0000, Sérgio Basto wrote: > Hi, > > On Thu, 2018-01-04 at 14:16 +0100, Jan Kurik wrote: > > - Add VirtualBox Guest Additions package to the default package list > > for the Workstation product > > I don't understand this one, VirtualBox Guest should *only* be > installed in an virtual machine . > > Today VirtualBox-server conflicts with VirtualBox-guest-additions and > vice versa . That's the root of the problem. And the fix is to make those packages smarter, so that they don't cause issues if they are present on a system where they are not useful. In https://bugzilla.rpmfusion.org/show_bug.cgi?id=3425#c14 Nicolas Chauvet gives a few good hints, e.g. to use udev rules to load the module conditionally. If this approach is not possible, it would even be possible to remove any automatic loading of the module and write a simple service that does some arbitrary checks and only loads the module after that. > I also propose the patch attach, to don't let install VirtualBox-guest- > additions in host systems, at the time could break the Xorg graphics > and all windows managers. I'm sorry, but I think that this is a terrible approach. Breaking an rpm transaction is hard on users, for example because it will break offline upgrades, and leave users in a state where they cannot recover easily. Having Conflicts between packages is slightly better, because the transaction will be aborted before it starts, but is also quite bad. Such approaches should be a thing of the past. For many years it has been expected that you can take one image and boot it as a container, a VM, a notebook, or a server, and have it boot correctly in all cases. Any service or driver which breaks this assumption should be considered buggy. Please find a way to make it possible to have both guest and server rpms installed, and enabled by default (in the sense that they'll be active under the right virtualization, and be a noop otherwise). In particular such flexibility is necessary to be able to treat virtualbox virtualization as all others, and, for example, to distribute a single guest image that will be fully useful in all virtualization implementations. > Furthermore at least is just a waste of disk space, for non virtual > machines and for who don't use VirtualBox. This is insignificant. > %pre guest-additions > +if [ $(systemd-detect-virt | grep -iP "oracle|kvm" -c) -eq 0 ]; then > +echo "This package it is only to install in one Oracle VM VirtualBox." > +echo "You are trying install VirtualBox guest-additions but it hasn't been \ > +detected that your system is running in a VirtualBox virtualization, so we \ > +forced the installation to fail." > +exit 1 > +fi No no no. We want generate an image and use it in multiple virtualization implementations. This approach would require that a vbox image is created under virtualbox, please don't require that. Zbyszek _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
