Brilliant! I was thinking about creating a proof of concept a posting it as a change myself.
However, I'm really busy with other projects, so I might miss F26.
Brad's suggestion made me happy, that's why I close the issue. Though, I would not
name the flag 'abrt' but 'tracebackcrash' or something like that. Its name should tell
users something about its effect.
I'm not sure how we package Go projects and how we build them, but my idea
is to include "--tags=tracebackcrash" in the build flags when running rpmbuild.
That means that we need to work with the rpm team and ask them to update
the default macros.
Will this change affect also gcc-go? I'm afraid that we need to come up with
something similar for gcc-go too, right?
Regards,
Jakub
Jakub
---------- Původní zpráva ----------
Od: Jakub Cajka <jcajka@xxxxxxxxxx>
Komu: Development discussions related to Fedora <devel@xxxxxxxxxxxxxxxxxxxxxxx>
Datum: 5. 1. 2017 16:38:03
Předmět: Re: F26 System Wide Change: Golang 1.8
----- Original Message -----
> From: jfilak@xxxxxxxxxxxxxxxxx
> To: "Development discussions related to Fedora" <devel@xxxxxxxxxxxxxxxxxxxxxxx>
> Sent: Wednesday, December 14, 2016 7:18:32 AM
> Subject: Re: F26 System Wide Change: Golang 1.8
>
> I agree with Zbyzsek on this.
>
> What about to carry a tiny down-stream patch until this issue is fixed:
> https://github.com/golang/go/issues/18304
>
>
> Jakub
>
>
Suggestion by Brad Fitzpatrick in the upstream issue seems as reasonable implementation to me. Also it make possible opt-out/opt-in, if there will be need for it.
I will work on implementing/testing it along with the re-base(including update to packaging macros and Go guidelines draft) and I will update the change proposal to reflect it ASAP.
Sorry for longer notice I have been offline though the end of the year,
JC
>
>
> ---------- Původní zpráva ----------
> Od: Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx>
> Komu: Development discussions related to Fedora
> <devel@xxxxxxxxxxxxxxxxxxxxxxx>
> Datum: 13. 12. 2016 19:35:01
> Předmět: Re: F26 System Wide Change: Golang 1.8
>
>
> On Tue, Dec 13, 2016 at 01:06:29PM -0500, Jakub Cajka wrote:
> > > can we enable coredumping for Go programs by default - i.e. set
> > > GOTRACEBACK=
> > > crash?
> > >
> > > Currently, Go terminate a process that panic and prints out an error
> > > message on stderr.
> > >
> > > This approach does not provide much room for automatic Go panic
> > > detection.
> >
> > It should be possible without any significant side effects apart from
> > generating cores and traces. But to enable this, I believe, it would need
> > alteration to the default system env.
>
> Would it be possible? What is the package providing the default env vars?
>
> systemd has DefaultEnvironment= in /etc/systemd/system.conf, but it is
> supposed to be used to create local overrides, and doesn't work well
> for this case (it's %config(noreplace) among other problems). In general
> setting global env vars does not work.
>
> Instead, it would be nicer to modify the go runtime to default to a coredump
> if GOTRACEBACK= is not set. This would cover more cases and would not pollute
> the environment for users who are not using go.
>
> Zbyszek
> _______________________________________________
> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
>
> _______________________________________________
> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
>
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
