On 08/02/2012 03:36 PM, Nathanael D. Noblet wrote:
On 08/02/2012 08:29 AM, Pierre-Yves Chibon wrote:Maybe it would be better formulated as: [!]: MUST: Buildroot MUST NOT be present (NOTE: this is not true for EPEL5) [!]: MUST: Package MUST NOT run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install What do you think?That would definitely be clearer to me.
Where is the guideline that says (as a MUST) that buildroot definition and cleaning must not be done (except for EPEL5)?
The packaging guidelines page (http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag) just says that it's not needed to define the buildroot from F-10, which is hardly a MUST; the only related MUST is that it MUST be defined for EPEL-5.
Similarly, buildroot cleaning (http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean) is listed as not required from F-13.
Leaving these in may enable a single spec to be used for all branches, including EPEL-5 if there aren't other reasons why a package wouldn't build on such an old distro, in which case it's harmless and advantageous to leave those in. I think the wording should reflect that these things are just redundant in modern distros and may be removed, but drop the MUST label.
Paul. -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
