On Thu, Sep 22, 2011 at 09:23:40PM +0200, Miloslav Trmač wrote: > On Thu, Sep 22, 2011 at 8:40 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > > On Thu, Sep 22, 2011 at 07:38:54PM +0100, Richard W.M. Jones wrote: > >> On Thu, Sep 22, 2011 at 05:37:39PM +0100, Matthew Garrett wrote: > >> We allow you to inspect the guest to find the OS version, and even > >> versions of individual packages installed in it. > > > > The package version of grub does nothing to tell you which version of > > grub is actually installed in the boot sector. > > That doesn't matter: When libguestfs runs its installation of grub, > the boot sector will be overwritten. What matters is the versions of > stage1/1.5/2 files in the guest, which is adequately described by > identifying the RPM. And now you're assuming that sector list will always be in the same place. Which also isn't guaranteed. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
