On 08/09/2011 07:19 PM, Jan Kratochvil wrote: > On Tue, 09 Aug 2011 19:14:27 +0200, Adam Jackson wrote: >> If you're volunteering to fix and/or paper over all the spurious >> warnings gcc and glibc introduce with every phase of the moon, then >> sure. > > Yes, I do it for my component, GDB has -Werror default in development phases > upstream. Yes, and gdb's best configuration feature is --disable-werrors, without which it was non-compilable almost everywhere. > It cleans up the code, it finds various minor bugs etc. Agreed, iff you are an upstream developer, otherwise not. In all other cases, it only causes minor issues (often negligible cosmetic stuff) being treated as errors, often causing Heisenbugs with each GCC/glibc release - Not worth mentioning the additional Heisenbugs you face when taking other OSes into consideration. >> Otherwise -Werror would essentially mean never shipping anything >> ever again. > > So the maintainers either care about the warnings - and then they should use > -Werror - or they do not care about the warnings - and then it does not matter > regarding warning messages which and how many of them can be found on the Koji > server in the log files. Please decide. I can only second what others already said: Switch off -Werror, unless you have too much time. > As always I guess it should be per maintainer / per package. Something like > default -Werror with easy opt-out. It often is not, but requires heavy modifications to a package. Something which often is beyond the skills of an occasional Fedora packager. > And we can forget about hiding the > compilation commands useful for toolchain troubleshooting. Well, ... are you sure your package has it's include paths and it's CFLAGS right? You won't see this class of bugs with AM_SILENT_RULES. Ralf -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
