On Thursday 16 June 2011 14:07:56 Mario Santagiuliana wrote: > In data 16/6/2011 14:46:59, Rex Dieter ha scritto: > > I don't think that's required, just take ownership, and update as > > normal. > > > > I see you've done that, but you missed "Fedora Devel" too. > > > > -- Rex > > I take the ownership for "Fedora devel" now. > Whatever I open a new review request for my spec file: > https://bugzilla.redhat.com/show_bug.cgi?id=713741 > > There was an inconsistency between spec file on fedora git repo scm master > branch and spec file in src fedora 14... > Than I remove some line in the spec file so I prefer a new review because > I'm new in fedora packager mantainer. So I follow these guidelines: > http://fedoraproject.org/wiki/PackageMaintainers/OrphanedPackages > > I hope anybody can take a quickly review. > > Thank you very much! The spec file is clean and all seems OK. Trying hard I would say that the %clean section is not needed because that is the default behavior for rpm. https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean Other than that I have no remarks. If you want to use this package to EPEL you should leave this line and add the standard BuildRoot. I hope this helps, -- Josà AbÃlio -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
