Re: Some blurriness in gnome desktop

[Martin Sourada <martin.sourada@xxxxxxxxx>]

On Mon, 2009-10-26 at 15:02 +0100, Martin Sourada wrote:
> On Mon, 2009-10-26 at 13:50 +0000, Bastien Nocera wrote:
> > Does the attached patch work for you for gnome-media?
> 
> If x0, y0, width and height are integer values (although they're passed
> as doubles I doubt they are actually non-integers), it should, I'm going
> to try build and test it. You would probably also want to use (but that
> depends on what you'd what the width/height values to represent).
> 
> x1 = x0 + width - 1; 
> 
> and similar for y1.
Actually, looking at in in the perspective of the whole code, this is
IMHO not the correct place to fix it as curved_rectangle() can be used
both for fills and for borders (even though in the file you use it only
in a way that fixing this in curved_rectangle() works too).

Attaching my version of the patch (verified that it works for me as
intended).

Martin

diff -up gnome-media-2.28.1/gnome-volume-control/src/gvc-level-bar.c.fix-blurriness-in-level gnome-media-2.28.1/gnome-volume-control/src/gvc-level-bar.c
--- gnome-media-2.28.1/gnome-volume-control/src/gvc-level-bar.c.fix-blurriness-in-level	2009-09-21 16:43:25.000000000 +0200
+++ gnome-media-2.28.1/gnome-volume-control/src/gvc-level-bar.c	2009-10-26 15:12:09.000000000 +0100
@@ -566,10 +566,10 @@ gvc_level_bar_expose (GtkWidget      *wi
                 for (i = 0; i < NUM_BOXES; i++) {
                         by = i * bar->priv->layout.delta;
                         curved_rectangle (cr,
-                                          bar->priv->layout.area.x,
-                                          by,
-                                          bar->priv->layout.box_width,
-                                          bar->priv->layout.box_height,
+                                          bar->priv->layout.area.x + 0.5,
+                                          by + 0.5,
+                                          bar->priv->layout.box_width - 1,
+                                          bar->priv->layout.box_height - 1,
                                           bar->priv->layout.box_radius);
                         if ((bar->priv->layout.max_peak_num - 1) == i) {
                                 /* fill peak foreground */
@@ -601,10 +601,10 @@ gvc_level_bar_expose (GtkWidget      *wi
                 for (i = 0; i < NUM_BOXES; i++) {
                         bx = i * bar->priv->layout.delta;
                         curved_rectangle (cr,
-                                          bx,
-                                          bar->priv->layout.area.y,
-                                          bar->priv->layout.box_width,
-                                          bar->priv->layout.box_height,
+                                          bx + 0.5,
+                                          bar->priv->layout.area.y + 0.5,
+                                          bar->priv->layout.box_width - 1,
+                                          bar->priv->layout.box_height - 1,
                                           bar->priv->layout.box_radius);
 
                         if ((bar->priv->layout.max_peak_num - 1) == i) {

Attachment: signature.asc
Description: This is a digitally signed message part

-- 
Fedora-desktop-list mailing list
Fedora-desktop-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-desktop-list