On Mon, 2009-10-26 at 13:47 +0100, Martin Sourada wrote:
> Hi all,
>
> I've been pondering this for a while, but there has been an increasing
> amount of blurriness in desktop UI elements that haven't been (most
> likely) designed by or even consulted with the gnome-art team (or fedora
> design team). Some examples include (the top part of each picture is
> screenshot, the bottom part is analogue done in inkscape to look crisp;
> ignore the coloring, it's not important in these images):
> * sound preferences [1]
Does the attached patch work for you for gnome-media?
> * volume control with compositing [2]
> * new tooltips [3]
>
> It does not seem that the blurriness is intentional, so I though I'd
> point it out. The problem is that if you're drawing fills you need to
> start at integer x,y values for position; when drawing borders, they
> need to be shifted by exactly half of their width (i.e. 0.5 px for 1px
> wide borders) to look crisp. We are not working with very high DPI
> display devices so this is important.
>
> I think fixing these would nicely fit with your "polishes for F12"
> project.
>
> Martin
>
> References:
> [1] http://mso.fedorapeople.org/gnome-blurry/sound-preferences.png
> [2] http://mso.fedorapeople.org/gnome-blurry/sound-volume.png
> [3] http://mso.fedorapeople.org/gnome-blurry/tooltips.png
> --
> Fedora-desktop-list mailing list
> Fedora-desktop-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/fedora-desktop-list
>From 582ad0502bea012b7e95acf9a7b7430ee8b485b9 Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@xxxxxxxxxx>
Date: Mon, 26 Oct 2009 13:48:42 +0000
Subject: [PATCH] Fix bluriness in level bar
By shifting the top-left coordinates by half a pixel, to match
the cairo grid.
---
gnome-volume-control/src/gvc-level-bar.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/gnome-volume-control/src/gvc-level-bar.c b/gnome-volume-control/src/gvc-level-bar.c
index e2c02e7..6c6e0bb 100644
--- a/gnome-volume-control/src/gvc-level-bar.c
+++ b/gnome-volume-control/src/gvc-level-bar.c
@@ -490,13 +490,15 @@ curved_rectangle (cairo_t *cr,
double x1;
double y1;
- x1 = x0 + width;
- y1 = y0 + height;
-
if (!width || !height) {
return;
}
+ x0 += 0.5;
+ y0 += 0.5;
+ x1 = x0 + width;
+ y1 = y0 + height;
+
if (width / 2 < radius) {
if (height / 2 < radius) {
cairo_move_to (cr, x0, (y0 + y1) / 2);
--
1.6.5.rc2
--
Fedora-desktop-list mailing list
Fedora-desktop-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-desktop-list
