On Mon, 2009-10-26 at 14:50 +0100, Martin Sourada wrote: > On Mon, 2009-10-26 at 13:34 +0000, Bastien Nocera wrote: > > The sound volume one has an upstream bug: > > https://bugzilla.gnome.org/show_bug.cgi?id=567249 > > > Nice to see people from gnome-art team noticed it as well. > > > Patch would be most welcome > If I find the code that's responsible for this, I'll look into how to > patch it. But no promises. > > Martin Hrm, this one was a little bit harder to find where the problem is... You are actually trying to draw it on non-integer position, which of course results in blurry volume bar in most cases. I've workarounded that by hard retyping the values to (int), but use whatever you prefer in your code to get the integer values out of the double ones. Quickly tested patch attached. I don't have more time to look at the tooltips ATM, maybe when I return. Martin
diff -up gnome-settings-daemon-2.28.1/plugins/media-keys/gsd-media-keys-window.c.fix-blurriness-in-composited-volume-bar gnome-settings-daemon-2.28.1/plugins/media-keys/gsd-media-keys-window.c
--- gnome-settings-daemon-2.28.1/plugins/media-keys/gsd-media-keys-window.c.fix-blurriness-in-composited-volume-bar 2009-10-26 15:33:04.000000000 +0100
+++ gnome-settings-daemon-2.28.1/plugins/media-keys/gsd-media-keys-window.c 2009-10-26 15:47:52.000000000 +0100
@@ -642,7 +642,7 @@ draw_volume_boxes (GsdMediaKeysWindow *w
r = (float)color.red / 65535.0;
g = (float)color.green / 65535.0;
b = (float)color.blue / 65535.0;
- rounded_rectangle (cr, 1.0, x0, y0, height / 6, width, height);
+ rounded_rectangle (cr, 1.0, ((int) x0) + 0.5, ((int) y0) + 0.5, height / 6, ((int) width) - 1, ((int) height) - 1);
cairo_set_source_rgba (cr, r, g, b, FG_ALPHA / 2);
cairo_fill_preserve (cr);
@@ -661,7 +661,7 @@ draw_volume_boxes (GsdMediaKeysWindow *w
r = (float)color.red / 65535.0;
g = (float)color.green / 65535.0;
b = (float)color.blue / 65535.0;
- rounded_rectangle (cr, 1.0, x0 + 1, y0 + 1, height / 8, x1, height - 2);
+ rounded_rectangle (cr, 1.0, ((int) x0) + 1, ((int) y0) + 1, height / 6 - 0.5, (int) x1, ((int) height) - 2);
cairo_set_source_rgba (cr, r, g, b, FG_ALPHA);
cairo_fill (cr);
}
Attachment:
signature.asc
Description: This is a digitally signed message part
-- Fedora-desktop-list mailing list Fedora-desktop-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-desktop-list
