Re: [PATCH libdrm 02/24] radeon: remove empty function declarations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1 April 2015 at 21:34, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote:
> On 1 April 2015 at 18:30, Jerome Glisse <j.glisse@xxxxxxxxx> wrote:
>> On Wed, Apr 01, 2015 at 05:15:13PM +0100, Emil Velikov wrote:
>>> Missing definition and unused since their introduction.
>>>
>>> Cc: Jerome Glisse <jglisse@xxxxxxxxxx>
>>> Signed-off-by: Emil Velikov <emil.l.velikov@xxxxxxxxx>
>>
>> NAK
>>
>> I use all this in tools to debug lockup. Best course of action is to
>> exclude bof.h from being distributed. My tools static link and i just
>> point them to libdrm git tree.
>>
> Did not notice any mention of such out-of-tree tools in the commit
> that introduced these functions, so I've naively assumed that they are
> unused.
Scratch that - I'm blind.

Upon closer look at your radeondb repo, I cannot see any static
linking in there. Also it seems that some of the functionality is
duplicated between the two. With the radeondb version being out of
date :'(

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux