On 1 April 2015 at 18:30, Jerome Glisse <j.glisse@xxxxxxxxx> wrote: > On Wed, Apr 01, 2015 at 05:15:13PM +0100, Emil Velikov wrote: >> Missing definition and unused since their introduction. >> >> Cc: Jerome Glisse <jglisse@xxxxxxxxxx> >> Signed-off-by: Emil Velikov <emil.l.velikov@xxxxxxxxx> > > NAK > > I use all this in tools to debug lockup. Best course of action is to > exclude bof.h from being distributed. My tools static link and i just > point them to libdrm git tree. > Did not notice any mention of such out-of-tree tools in the commit that introduced these functions, so I've naively assumed that they are unused. Sorry about that. Do you mind if I add a note about it, or alternatively will you be ok with pushing your tool to libdrm ? The Intel team already have a test_decode tool in, which is similar in nature. I'm not sure that your suggestion will work - one cannot exclude bof.h (and bof.c) from the distribution as it's used by radeon_cs_gem.c. Annotating the symbols as hidden/private should work for everyone. How does that sound ? ... >> -extern int bof_file_flush(bof_t *root); >> -extern bof_t *bof_file_new(const char *filename); >> -extern int bof_object_dump(bof_t *object, const char *filename); >> - Can you please elaborate how you are using these three, do you have them implemented outside of libdrm as well ? Cheers, Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
