On Fri, Mar 21, 2025 at 12:23:15PM +0000, Srinivas Kandagatla wrote: > > > On 20/03/2025 18:43, Dmitry Baryshkov wrote: > > On Thu, Mar 20, 2025 at 05:11:20PM +0000, Srinivas Kandagatla wrote: > > > > > > > > > On 20/03/2025 09:14, Ling Xu wrote: > > > > The fastrpc driver has support for 5 types of remoteprocs. There are > > > > some products which support GPDSP remoteprocs. Add changes to support > > > > GPDSP remoteprocs. > > > > > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx> > > > > Signed-off-by: Ling Xu <quic_lxu5@xxxxxxxxxxx> > > > > --- > > > > drivers/misc/fastrpc.c | 10 ++++++++-- > > > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > > > > index 7b7a22c91fe4..80aa554b3042 100644 > > > > --- a/drivers/misc/fastrpc.c > > > > +++ b/drivers/misc/fastrpc.c > > > > @@ -28,7 +28,9 @@ > > > > #define SDSP_DOMAIN_ID (2) > > > > #define CDSP_DOMAIN_ID (3) > > > > #define CDSP1_DOMAIN_ID (4) > > > > -#define FASTRPC_DEV_MAX 5 /* adsp, mdsp, slpi, cdsp, cdsp1 */ > > > > +#define GDSP0_DOMAIN_ID (5) > > > > +#define GDSP1_DOMAIN_ID (6) > > > > > > We have already made the driver look silly here, Lets not add domain ids for > > > each instance, which is not a scalable. > > > > > > Domain ids are strictly for a domain not each instance. > > > > Then CDSP1 should also be gone, correct? > Its already gone as part of the patch that I shared in this discussion. > > I will send a proper patch to list once Ling/Ekansh has agree with it. I see. For some reason mobile gmail decided that your patch is a quoted message and ignored it. -- With best wishes Dmitry
