On Sun, Mar 16, 2025 at 11:15:11AM -0300, Maíra Canal wrote: > To prevent future changes that might inadvertently break the ABI, add > more examples to the binding. These examples improve coverage and help Examples are not related to ABI at all. > ensure `make dt_binding_check` produces more robust validation results. No, don't add more examples differing by one property. Keep one/two examples. > > Signed-off-by: Maíra Canal <mcanal@xxxxxxxxxx> > --- > .../devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 34 ++++++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml > index 766a310ab653855d7cc9a80f18c2083218fe307e..39b8f0ee1f727628307d758844008ae1189902b2 100644 > --- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml > +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml > @@ -123,6 +123,38 @@ allOf: > additionalProperties: false > > examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/soc/bcm2835-pm.h> > + > + gpu@7ec00000 { > + compatible= "brcm,2711-v3d"; > + reg = <0x7ec00000 0x4000>, > + <0x7ec04000 0x4000>; > + reg-names = "hub", "core0"; > + > + power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>; That's the only notable difference - one new property. > + resets = <&pm BCM2835_RESET_V3D>; > + interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>; > + }; > + > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/soc/bcm2835-pm.h> > + > + gpu@2000000 { > + compatible = "brcm,2712-v3d"; > + reg = <0x02000000 0x4000>, > + <0x02008000 0x6000>, > + <0x02030800 0x0700>; > + reg-names = "hub", "core0", "sms"; > + > + power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>; > + resets = <&pm BCM2835_RESET_V3D>; > + interrupts = <GIC_SPI 250 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 249 IRQ_TYPE_LEVEL_HIGH>; No differences here at all. Best regards, Krzysztof