On Mon, Mar 03, 2025 at 09:31:06AM +0100, Arnd Bergmann wrote: > On Mon, Mar 3, 2025, at 08:48, Andy Shevchenko wrote: > > On Fri, Feb 28, 2025 at 09:08:15PM +0200, Raag Jadav wrote: > >> > > > Ah, you mean devres related? > >> > > > >> > > Yeah, couldn't find it on Arnd's tree and I'm not sure if this series > >> > > works without it. > >> > > >> > But err.h is included in the io.h, no? Or did I misunderstand the point? > >> > >> First patch on the immutable tag moves IOMEM_ERR_PTR() to err.h and here > >> we're dropping err.h from io.h. So without the tag this series will probably > >> break IOMEM_ERR_PTR(). > > > > I see, I think it might be due to some other includes that make this happen. > > Whatever, I assume that Arnd heavily tested this anyway, so it's good to go > > independently on the immutable tag.. > > I see that err.h gets included through at least linux/string.h, > linux/logic_pio.h and (depending on the architecture architectures) > asm/page.h, so there is no huge risk of something breaking here ;-) > > Ideally all of the above should be removed here, but to do > it right, the linux/pgtable.h dependency needs to also be replaced > with a smaller pgprot_t specific one, which takes a bit of > cross-platform work as the definition is not in a consistent > place at the moment. > > The change below still builds fine, and that likely indicates > that the same headers are still included from either asm/io.h > or asm/pgtable.h on the architectures I'm testing. Sounds even better. Can you submit a formal patch that other CIs will have a chance to go through this? -- With Best Regards, Andy Shevchenko
