Re: [PATCH v3 0/2] Cleanup io.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 28, 2025 at 08:52:51PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 28, 2025 at 08:45:26PM +0200, Raag Jadav wrote:
> > On Fri, Feb 28, 2025 at 08:42:10PM +0200, Andy Shevchenko wrote:
> > > On Fri, Feb 28, 2025 at 08:41:33PM +0200, Andy Shevchenko wrote:
> > > > On Fri, Feb 28, 2025 at 07:41:55PM +0200, Raag Jadav wrote:
> > > > > On Fri, Feb 28, 2025 at 06:11:16PM +0100, Arnd Bergmann wrote:
> > > > > > On Thu, Feb 27, 2025, at 16:25, Andy Shevchenko wrote:
> > > > > > > On Thu, Feb 27, 2025 at 12:37:45PM +0530, Raag Jadav wrote:
> > > > > > >> This series attempts to cleanup io.h with "include what you use" approach.
> > > > > > >> This depends on changes available on immutable tag[1].
> > > > > > >> 
> > > > > > >> Although this series is too trivial in the grand scheme of things, it is
> > > > > > >> still a tiny step towards untangling core headers. I have success results
> > > > > > >> from LKP for this series but there can still be corner cases. So perhaps
> > > > > > >> we can queue this on a temporary branch which we can use to submit fixes
> > > > > > >> in case of fallout.
> > > > > > >> 
> > > > > > >> Future plan is to use the excellent analysis[2][3] by Arnd to cleanup other
> > > > > > >> headers.
> > > > > > >> 
> > > > > > >> [1] https://lore.kernel.org/r/Z7xGpz3Q4Zj6YHx7@xxxxxxxxxxxxxxxxxx
> > > > > > >> [2] https://lore.kernel.org/r/2342b516-2c6e-42e5-b4f4-579b280823ba@xxxxxxxxxxxxxxxx
> > > > > > >> [3] https://lore.kernel.org/r/f6eb011b-40fb-409a-b2b2-a09d0e770bbd@xxxxxxxxxxxxxxxx
> > > > > > >
> > > > > > > I believe Arnd can take it through his tree for headers as DRM part is 
> > > > > > > Acked already.
> > > > > > 
> > > > > > I've applied it yesterday and not seen any regression reports so far.
> > > > > 
> > > > > Probably because the immutable tag is already in -next?
> > > > 
> > > > Is there any?
> > > 
> > > Ah, you mean devres related?
> > 
> > Yeah, couldn't find it on Arnd's tree and I'm not sure if this series
> > works without it.
> 
> But err.h is included in the io.h, no? Or did I misunderstand the point?

First patch on the immutable tag moves IOMEM_ERR_PTR() to err.h and here
we're dropping err.h from io.h. So without the tag this series will probably
break IOMEM_ERR_PTR().

Raag



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux