On Wed, Feb 26, 2025 at 12:45:45AM +0100, Danilo Krummrich wrote: > On Tue, Feb 25, 2025 at 06:57:56PM -0400, Jason Gunthorpe wrote: > > The common driver shutdown process in the kernel, that is well tested > > and copied, makes the driver single threaded during the remove() > > callback. > > All devres callbacks run in the same callchain, __device_release_driver() first > calls remove() and then all the devres callbacks, where we revoke the pci::Bar, > by which gets dropped and hence the bar is unmapped and resource regions are > free. It's not different to C drivers. Except that in C you don't lose access to > the void pointer that still points to the (unmapped) MMIO address. I understand how devm works. I'm pointing out the fundamental different in approachs. The typical widely used pattern results in __device_release_driver() completing with no concurrent driver code running. DRM achieves this, in part, by using drm_dev_unplug(). The Rust approach ends up with __device_release_driver() completing and leaving driver code still running in other threads. This is a significant different outcome that must be mitigated somehow to prevent an Execute After Free failure for Rust. DRM happens to be safe because it ends up linking the driver module refcount to FD lifetime. This also prevents unloading the driver (bad!!). However, for instance, you can't rely on the module reference count with work queues, so this scheme is not generally applicable. Jason
