On 20.02.2025 12:14 PM, Dmitry Baryshkov wrote:
> We can check the LCDC clock directly from the LCDC encoder driver, so
> remove it from the LVDS connector.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.h | 1 -
> drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 27 ++++++++++++++++------
> .../gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c | 21 -----------------
> 3 files changed, 20 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.h b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.h
> index b8bdc3712c73b14f3547dce3439a895e3d10f193..e0380d3b7e0cee99c4c376bf6369887106f44ede 100644
> --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.h
> +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.h
> @@ -191,7 +191,6 @@ struct drm_crtc *mdp4_crtc_init(struct drm_device *dev,
> long mdp4_dtv_round_pixclk(struct drm_encoder *encoder, unsigned long rate);
> struct drm_encoder *mdp4_dtv_encoder_init(struct drm_device *dev);
>
> -long mdp4_lcdc_round_pixclk(struct drm_encoder *encoder, unsigned long rate);
> struct drm_encoder *mdp4_lcdc_encoder_init(struct drm_device *dev,
> struct device_node *panel_node);
>
> diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c
> index db93795916cdaa87ac8e61d3b44c2dadac10fd9e..cfcedd8a635cf0297365e845ef415a8f0d553183 100644
> --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c
> @@ -348,19 +348,32 @@ static void mdp4_lcdc_encoder_enable(struct drm_encoder *encoder)
> mdp4_lcdc_encoder->enabled = true;
> }
>
> +static enum drm_mode_status
> +mdp4_lcdc_encoder_mode_valid(struct drm_encoder *encoder,
> + const struct drm_display_mode *mode)
> +{
> + struct mdp4_lcdc_encoder *mdp4_lcdc_encoder =
> + to_mdp4_lcdc_encoder(encoder);
Crazy linebreak
> + long actual, requested;
> +
> + requested = 1000 * mode->clock;
> + actual = clk_round_rate(mdp4_lcdc_encoder->lcdc_clk, requested);
> +
> + DBG("requested=%ld, actual=%ld", requested, actual);
> +
> + if (actual != requested)
> + return MODE_CLOCK_RANGE;
> +
> + return MODE_OK;
> +}
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad
