On Fri, Feb 14, 2025 at 02:17:45PM +0100, Krzysztof Kozlowski wrote: > dsi_get_config(), dsi_clk_init() and msm_dsi_host_init() are called only > from platform driver probe function, so using dev_err_probe() is both > appropriate and beneficial: > - Properly marks device deferred probe status, > - Avoids dmesg flood on probe deferrals, > - Already incorporates printing ERR value, > - Shows device name (in contrast to pr_err()), > - Makes code smaller and simpler. > > Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > Changes in v2: > 1. Update commit msg > 2. Tags > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 100 +++++++++++++++---------------------- > 1 file changed, 41 insertions(+), 59 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry