On Fri, Feb 14, 2025 at 02:17:44PM +0100, Krzysztof Kozlowski wrote: > dsi_clk_init(), which gets the clocks, is called only through platform > driver probe and its failure is a failure of the probe. Therefore > NULL-ifying specific clocks is pointless and redundant - the PTR_ERR > value stored there won't be used/dereferenced afterwards. What's more, > variant-specific clock init calls like dsi_clk_init_6g_v2() are not > doing this cleanup. Dropping redundant code allows later to make this a > bit simpler. > > Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 3 --- > 1 file changed, 3 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry
