On Thu Feb 13, 2025 at 3:54 PM CET, Piotr Oniszczuk wrote: > > >> Wiadomość napisana przez Damon Ding <damon.ding@xxxxxxxxxxxxxx> w dniu 23 sty 2025, o godz. 11:07: >> >> Picked from: >> https://patchwork.kernel.org/project/linux-rockchip/list/?series=923593 >> >> These patchs have been tested with a 1536x2048p60 eDP panel on >> RK3588S EVB1 board, and HDMI 1080P/4K display also has been verified >> on RK3588 EVB1 board. Furthermore, the eDP display has been rechecked >> on RK3399 sapphire excavator board. >> ... >> 9 files changed, 401 insertions(+), 89 deletions(-) >> >> -- >> 2.34.1 >> > > Damon, > > I’m playing with hdmi0 port enablement on radxa rock5 itx board with 6.14 mainline. > > rock5 itx has 2 hdmi ports: hdmi0 is wired to rk3588 typeC1/eDP1 eDP with ra620 eDP->HDMI converter and hdmi1 from hdmi/edp tx1 > (see page3 & page29 at https://dl.radxa.com/rock5/5itx/v1110/radxa_rock_5itx_v1110_schematic.pdf) > > I’m on 6.14-rc2 with applied: > [1] Cristicc hdmi code (https://gitlab.collabora.com/cristicc/linux-next/-/commits/rk3588-hdmi-bridge) > [2] eDP support for RK3588 (https://patchwork.kernel.org/project/linux-rockchip/list/?series=927765) > [3] Add eDP mode support for Rockchip Samsung HDPTX PHY (https://patchwork.kernel.org/project/linux-rockchip/cover/20250205105157.580060-1-damon.ding@xxxxxxxxxxxxxx/) > > Is edp1 supported by yours [2] series? > > If yes - may you pls hint me about required dts additions in https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts?h=v6.14-rc2 ? I don't know if it's relevant, but while HDMI0 got enabled for quite a few devices in 6.13, it did NOT get enabled for Rock 5 ITX. I made a local patch (which does the same thing as was done for Rock 5B) but I have no idea if it actually works (I don't have the board). Maybe you need that for eDP to work? Cheers, Diederik
From 5156cfb53ac20887cf3ceb8598b3f35ee74161e9 Mon Sep 17 00:00:00 2001 From: Diederik de Haas <didi.debian@xxxxxxxxx> Date: Sat, 2 Nov 2024 00:10:20 +0100 Subject: [PATCH] arm64: dts: rockchip: Enable HDMI0 on ROCK 5 ITX Add the necessary DT changes to enable HDMI0 on Radxa ROCK 5 ITX. This is the same patch as for the ROCK 5B, but then adjusted for the ROCK 5 ITX's context, but the new statements are exactly the same. Signed-off-by: Diederik de Haas <didi.debian@xxxxxxxxx> Link: https://lore.kernel.org/all/20241019-rk3588-hdmi0-dt-v2-0-466cd80e8ff9@xxxxxxxxxxxxx/ --- .../boot/dts/rockchip/rk3588-rock-5-itx.dts | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts index 6d68f70284e4..a1b89aba977d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts @@ -11,6 +11,7 @@ #include <dt-bindings/leds/common.h> #include <dt-bindings/pinctrl/rockchip.h> #include <dt-bindings/pwm/pwm.h> +#include <dt-bindings/soc/rockchip,vop2.h> #include "dt-bindings/usb/pd.h" #include "rk3588.dtsi" @@ -72,6 +73,17 @@ hdd-led2 { }; }; + hdmi0-con { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi0_con_in: endpoint { + remote-endpoint = <&hdmi0_out_con>; + }; + }; + }; + /* Unnamed gated oscillator: 100MHz,3.3V,3225 */ pcie30_port0_refclk: pcie30_port1_refclk: pcie-oscillator { compatible = "gated-fixed-clock"; @@ -261,6 +273,26 @@ &gpu { status = "okay"; }; +&hdmi0 { + status = "okay"; +}; + +&hdmi0_in { + hdmi0_in_vp0: endpoint { + remote-endpoint = <&vp0_out_hdmi0>; + }; +}; + +&hdmi0_out { + hdmi0_out_con: endpoint { + remote-endpoint = <&hdmi0_con_in>; + }; +}; + +&hdptxphy_hdmi0 { + status = "okay"; +}; + &i2c0 { pinctrl-names = "default"; pinctrl-0 = <&i2c0m2_xfer>; @@ -1209,3 +1241,18 @@ &usbdp_phy1 { rockchip,dp-lane-mux = <2 3>; status = "okay"; }; + +&vop_mmu { + status = "okay"; +}; + +&vop { + status = "okay"; +}; + +&vp0 { + vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 { + reg = <ROCKCHIP_VOP2_EP_HDMI0>; + remote-endpoint = <&hdmi0_in_vp0>; + }; +}; -- 2.47.2
Attachment:
signature.asc
Description: PGP signature
