On Tue, Feb 04, 2025 at 03:57:55PM +0100, Maxime Ripard wrote: > The drm_bridge structure contains an encoder pointer that is widely used > by bridge drivers. This pattern is largely documented as deprecated in > other KMS entities for atomic drivers. > > However, one of the main use of that pointer is done in attach to just > call drm_bridge_attach on the next bridge to add it to the bridge list. > While this dereferences the bridge->encoder pointer, it's effectively > the same encoder the bridge was being attached to. > > We can make it more explicit by adding the encoder the bridge is > attached to to the list of attach parameters. This also removes the need > to dereference bridge->encoder in most drivers. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> Note, tc358767.c and ti-sn65dsi86.c also has several bridge.encoder uses in attach callbacks. Also, we still have a lot of usecases for bridge->encoder. including core functions like drm_bridge_get_next_bridge() and drm_bridge_get_prev_bridge(). Maybe that's handled in a later patches. > > Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx> > --- > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 ++- > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 ++- > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 3 ++- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +- > drivers/gpu/drm/bridge/analogix/anx7625.c | 3 ++- > drivers/gpu/drm/bridge/aux-bridge.c | 3 ++- > drivers/gpu/drm/bridge/aux-hpd-bridge.c | 1 + > drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 3 ++- > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 + > drivers/gpu/drm/bridge/chipone-icn6211.c | 6 ++++-- > drivers/gpu/drm/bridge/chrontel-ch7033.c | 5 +++-- > drivers/gpu/drm/bridge/display-connector.c | 1 + > drivers/gpu/drm/bridge/fsl-ldb.c | 3 ++- > drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 7 +++---- > drivers/gpu/drm/bridge/imx/imx-ldb-helper.h | 2 +- > drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 3 ++- > drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 3 ++- > drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 3 ++- > drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 3 ++- > drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 3 ++- > drivers/gpu/drm/bridge/ite-it6263.c | 7 ++++--- > drivers/gpu/drm/bridge/ite-it6505.c | 1 + > drivers/gpu/drm/bridge/ite-it66121.c | 3 ++- > drivers/gpu/drm/bridge/lontium-lt8912b.c | 3 ++- > drivers/gpu/drm/bridge/lontium-lt9211.c | 3 ++- > drivers/gpu/drm/bridge/lontium-lt9611.c | 3 ++- > drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 3 ++- > drivers/gpu/drm/bridge/lvds-codec.c | 3 ++- > drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 1 + > drivers/gpu/drm/bridge/microchip-lvds.c | 3 ++- > drivers/gpu/drm/bridge/nwl-dsi.c | 3 ++- > drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 +++-- > drivers/gpu/drm/bridge/panel.c | 3 ++- > drivers/gpu/drm/bridge/parade-ps8622.c | 1 + > drivers/gpu/drm/bridge/parade-ps8640.c | 3 ++- > drivers/gpu/drm/bridge/samsung-dsim.c | 3 ++- > drivers/gpu/drm/bridge/sii902x.c | 5 +++-- > drivers/gpu/drm/bridge/sil-sii8620.c | 1 + > drivers/gpu/drm/bridge/simple-bridge.c | 5 +++-- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 5 +++-- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c | 5 +++-- > drivers/gpu/drm/bridge/tc358762.c | 3 ++- > drivers/gpu/drm/bridge/tc358764.c | 3 ++- > drivers/gpu/drm/bridge/tc358767.c | 2 ++ > drivers/gpu/drm/bridge/tc358768.c | 3 ++- > drivers/gpu/drm/bridge/tc358775.c | 3 ++- > drivers/gpu/drm/bridge/thc63lvd1024.c | 3 ++- > drivers/gpu/drm/bridge/ti-dlpc3433.c | 4 ++-- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 3 ++- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 ++- > drivers/gpu/drm/bridge/ti-tdp158.c | 6 ++++-- > drivers/gpu/drm/bridge/ti-tfp410.c | 5 +++-- > drivers/gpu/drm/bridge/ti-tpd12s015.c | 3 ++- > drivers/gpu/drm/drm_bridge.c | 2 +- > drivers/gpu/drm/i2c/tda998x_drv.c | 1 + > drivers/gpu/drm/imx/ipuv3/parallel-display.c | 3 ++- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 5 +++-- > drivers/gpu/drm/mcde/mcde_dsi.c | 3 ++- > drivers/gpu/drm/mediatek/mtk_dp.c | 3 ++- > drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++- > drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 ++- > drivers/gpu/drm/meson/meson_encoder_cvbs.c | 3 ++- > drivers/gpu/drm/meson/meson_encoder_dsi.c | 3 ++- > drivers/gpu/drm/meson/meson_encoder_hdmi.c | 3 ++- > drivers/gpu/drm/msm/dsi/dsi_manager.c | 3 ++- > drivers/gpu/drm/omapdrm/dss/dpi.c | 3 ++- > drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++- > drivers/gpu/drm/omapdrm/dss/hdmi4.c | 3 ++- > drivers/gpu/drm/omapdrm/dss/hdmi5.c | 3 ++- > drivers/gpu/drm/omapdrm/dss/sdi.c | 3 ++- > drivers/gpu/drm/omapdrm/dss/venc.c | 3 ++- > drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c | 3 ++- > drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 3 ++- > drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 3 ++- > drivers/gpu/drm/stm/lvds.c | 11 +++++------ > drivers/gpu/drm/tidss/tidss_encoder.c | 3 ++- > drivers/gpu/drm/vc4/vc4_dsi.c | 3 ++- > drivers/gpu/drm/xlnx/zynqmp_dp.c | 3 ++- > drivers/platform/arm64/acer-aspire1-ec.c | 3 ++- > include/drm/drm_bridge.h | 2 +- > 82 files changed, 170 insertions(+), 94 deletions(-) -- With best wishes Dmitry
