Hi, Here's a series of changes after to the KMS helpers and bridge API following a bunch of reviews I did. It's mostly centered across providing an easier time to deal with bridge states, and a somewhat consistent with the other entities API. It's build tested only, with arm64 allmodconfig. Maxime Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx> --- Changes in v2: - Pass the full atomic state to bridge atomic hooks - Make attach take the encoder as a parameter - Mark bridge->encoder as deprecated - Rework the logic to detect if a bridge uses a state or not at atomic_check time - Add lockdep assertion to drm_bridge_get_current_state() - Link to v1: https://lore.kernel.org/r/20250115-bridge-connector-v1-0-9a2fecd886a6@xxxxxxxxxx --- Maxime Ripard (35): drm/atomic: Document history of drm_atomic_state drm/bridge: Pass full state to atomic_pre_enable drm/bridge: Pass full state to atomic_enable drm/bridge: Pass full state to atomic_disable drm/bridge: Pass full state to atomic_post_disable drm/atomic-helper: Fix commit_tail state variable name drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_dependencies() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail_rpm() drm/atomic-helper: Change parameter name of drm_atomic_helper_modeset_disables() drm/atomic-helper: Change parameter name of disable_outputs() drm/bridge: Change parameter name of drm_atomic_bridge_chain_disable() drm/bridge: Change parameter name of drm_atomic_bridge_chain_post_disable() drm/atomic-helper: Change parameter name of drm_atomic_helper_update_legacy_modeset_state() drm/atomic-helper: Change parameter name of crtc_set_mode() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_planes() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_modeset_enables() drm/bridge: Change parameter name of drm_atomic_bridge_chain_pre_enable() drm/bridge: Change parameter name of drm_atomic_bridge_chain_enable() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_writebacks() drm/atomic-helper: Change parameter name of drm_atomic_helper_fake_vblank() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_hw_done() drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_vblanks() drm/atomic-helper: Change parameter name of drm_atomic_helper_cleanup_planes() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_cleanup_done() drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_flip_done() drm/bridge: Add encoder parameter to drm_bridge_funcs.attach drm/bridge: Provide a helper to retrieve current bridge state drm/bridge: Assume that a bridge is atomic if it has atomic_reset drm/bridge: Provide pointers to the connector and crtc in bridge state drm/bridge: Make encoder pointer deprecated drm/bridge: cdns-csi: Switch to atomic helpers drm/bridge: tc358775: Switch to atomic commit drm/bridge: tc358768: Convert to atomic helpers drm/bridge: ti-sn65dsi86: Use bridge_state crtc pointer drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 +- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 3 +- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 26 +-- drivers/gpu/drm/bridge/analogix/anx7625.c | 11 +- drivers/gpu/drm/bridge/aux-bridge.c | 3 +- drivers/gpu/drm/bridge/aux-hpd-bridge.c | 1 + drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 30 ++- .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 +- drivers/gpu/drm/bridge/chipone-icn6211.c | 13 +- drivers/gpu/drm/bridge/chrontel-ch7033.c | 5 +- drivers/gpu/drm/bridge/display-connector.c | 1 + drivers/gpu/drm/bridge/fsl-ldb.c | 8 +- drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 7 +- drivers/gpu/drm/bridge/imx/imx-ldb-helper.h | 2 +- drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 3 +- drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 10 +- drivers/gpu/drm/bridge/imx/imx8qm-ldb.c | 10 +- drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 21 +- .../gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 8 +- drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 13 +- drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 11 +- drivers/gpu/drm/bridge/ite-it6263.c | 18 +- drivers/gpu/drm/bridge/ite-it6505.c | 10 +- drivers/gpu/drm/bridge/ite-it66121.c | 8 +- drivers/gpu/drm/bridge/lontium-lt8912b.c | 3 +- drivers/gpu/drm/bridge/lontium-lt9211.c | 8 +- drivers/gpu/drm/bridge/lontium-lt9611.c | 21 +- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 3 +- drivers/gpu/drm/bridge/lvds-codec.c | 3 +- .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 1 + drivers/gpu/drm/bridge/microchip-lvds.c | 3 +- drivers/gpu/drm/bridge/nwl-dsi.c | 13 +- drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 +- drivers/gpu/drm/bridge/panel.c | 15 +- drivers/gpu/drm/bridge/parade-ps8622.c | 1 + drivers/gpu/drm/bridge/parade-ps8640.c | 7 +- drivers/gpu/drm/bridge/samsung-dsim.c | 11 +- drivers/gpu/drm/bridge/sii902x.c | 9 +- drivers/gpu/drm/bridge/sil-sii8620.c | 1 + drivers/gpu/drm/bridge/simple-bridge.c | 5 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 5 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 8 +- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 11 +- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c | 11 +- drivers/gpu/drm/bridge/tc358762.c | 12 +- drivers/gpu/drm/bridge/tc358764.c | 3 +- drivers/gpu/drm/bridge/tc358767.c | 22 +- drivers/gpu/drm/bridge/tc358768.c | 33 ++- drivers/gpu/drm/bridge/tc358775.c | 39 ++-- drivers/gpu/drm/bridge/thc63lvd1024.c | 3 +- drivers/gpu/drm/bridge/ti-dlpc3433.c | 10 +- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 10 +- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 63 ++++-- drivers/gpu/drm/bridge/ti-tdp158.c | 12 +- drivers/gpu/drm/bridge/ti-tfp410.c | 5 +- drivers/gpu/drm/bridge/ti-tpd12s015.c | 3 +- drivers/gpu/drm/drm_atomic_helper.c | 242 ++++++++++----------- drivers/gpu/drm/drm_atomic_state_helper.c | 5 + drivers/gpu/drm/drm_bridge.c | 98 +++------ drivers/gpu/drm/i2c/tda998x_drv.c | 1 + drivers/gpu/drm/imx/ipuv3/parallel-display.c | 3 +- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 9 +- drivers/gpu/drm/mcde/mcde_dsi.c | 3 +- drivers/gpu/drm/mediatek/mtk_dp.c | 9 +- drivers/gpu/drm/mediatek/mtk_dpi.c | 3 +- drivers/gpu/drm/mediatek/mtk_dsi.c | 11 +- drivers/gpu/drm/mediatek/mtk_hdmi.c | 12 +- drivers/gpu/drm/meson/meson_encoder_cvbs.c | 8 +- drivers/gpu/drm/meson/meson_encoder_dsi.c | 8 +- drivers/gpu/drm/meson/meson_encoder_hdmi.c | 8 +- drivers/gpu/drm/msm/dp/dp_display.c | 28 +-- drivers/gpu/drm/msm/dp/dp_drm.c | 19 +- drivers/gpu/drm/msm/dp/dp_drm.h | 6 +- drivers/gpu/drm/msm/dsi/dsi_manager.c | 3 +- drivers/gpu/drm/omapdrm/dss/dpi.c | 3 +- drivers/gpu/drm/omapdrm/dss/dsi.c | 3 +- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 8 +- drivers/gpu/drm/omapdrm/dss/hdmi5.c | 8 +- drivers/gpu/drm/omapdrm/dss/sdi.c | 3 +- drivers/gpu/drm/omapdrm/dss/venc.c | 3 +- drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c | 8 +- drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 7 +- drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 8 +- drivers/gpu/drm/stm/lvds.c | 16 +- drivers/gpu/drm/tidss/tidss_encoder.c | 3 +- drivers/gpu/drm/vc4/vc4_dsi.c | 12 +- drivers/gpu/drm/xlnx/zynqmp_dp.c | 17 +- drivers/platform/arm64/acer-aspire1-ec.c | 3 +- include/drm/drm_atomic.h | 45 ++++ include/drm/drm_bridge.h | 39 +++- 91 files changed, 681 insertions(+), 574 deletions(-) --- base-commit: 50d0a57d3a4193862a53fae0de7ed7749908cd8f change-id: 20250115-bridge-connector-f93194e267ff Best regards, -- Maxime Ripard <mripard@xxxxxxxxxx>
