On Mon, 27 Jan 2025 08:10:02 +0100, Arnd Bergmann wrote: > Without the DP helper code, the newly added displayport support > causes a link failure: > > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.o: in function `hibmc_dp_aux_init': > dp_aux.c:(.text+0x37e): undefined reference to `drm_dp_aux_init' > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_set_pattern': > dp_link.c:(.text+0xae): undefined reference to `drm_dp_dpcd_write' > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_get_adjust_train': > dp_link.c:(.text+0x121): undefined reference to `drm_dp_get_adjust_request_voltage' > x86_64-linux-ld: dp_link.c:(.text+0x12e): undefined reference to `drm_dp_get_adjust_request_pre_emphasis' > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_training': > dp_link.c:(.text+0x2b0): undefined reference to `drm_dp_dpcd_write' > x86_64-linux-ld: dp_link.c:(.text+0x2e3): undefined reference to `drm_dp_dpcd_write' > > [...] Applied to drm-misc-fixes, thanks! [1/1] drm/hisilicon/hibmc: select CONFIG_DRM_DISPLAY_DP_HELPER commit: 9ab127a18018fb06bd42a54ed38bb7b8c449d686 Best regards, -- With best wishes Dmitry