On Mon, Jan 27, 2025 at 08:10:02AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Without the DP helper code, the newly added displayport support
> causes a link failure:
>
> x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.o: in function `hibmc_dp_aux_init':
> dp_aux.c:(.text+0x37e): undefined reference to `drm_dp_aux_init'
> x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_set_pattern':
> dp_link.c:(.text+0xae): undefined reference to `drm_dp_dpcd_write'
> x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_get_adjust_train':
> dp_link.c:(.text+0x121): undefined reference to `drm_dp_get_adjust_request_voltage'
> x86_64-linux-ld: dp_link.c:(.text+0x12e): undefined reference to `drm_dp_get_adjust_request_pre_emphasis'
> x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_training':
> dp_link.c:(.text+0x2b0): undefined reference to `drm_dp_dpcd_write'
> x86_64-linux-ld: dp_link.c:(.text+0x2e3): undefined reference to `drm_dp_dpcd_write'
>
> Add both DRM_DISPLAY_DP_HELPER and DRM_DISPLAY_HELPER, which is
> in turn required by the former.
>
> Fixes: 0ab6ea261c1f ("drm/hisilicon/hibmc: add dp module in hibmc")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>
--
With best wishes
Dmitry
